linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Yufen Yu <yuyufen@huawei.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, jack@suse.cz,
	Hannes Reinecke <hare@suse.de>,
	damien.lemoal@wdc.com
Subject: Re: [PATCH] block: check disk exist before trying to add partition
Date: Thu, 10 Jun 2021 14:28:28 +0800	[thread overview]
Message-ID: <CAFj5m9K1Psc91zvNipb+PKp+zDeFjOKCu+rv3EC9H+1M8gPKiw@mail.gmail.com> (raw)
In-Reply-To: <20210608092707.1062259-1-yuyufen@huawei.com>

On Tue, Jun 8, 2021 at 5:21 PM Yufen Yu <yuyufen@huawei.com> wrote:
>
> If disk have been deleted, we should return fail for ioctl
> BLKPG_DEL_PARTITION. Otherwise, the directory /sys/class/block
> may remain invalid symlinks file. The race as following:
>
> blkdev_open
>                                 del_gendisk
>                                     disk->flags &= ~GENHD_FL_UP;
>                                     blk_drop_partitions
> blkpg_ioctl
>     bdev_add_partition
>     add_partition
>         device_add
>             device_add_class_symlinks
>
> ioctl may add_partition after del_gendisk() have tried to delete
> partitions. Then, symlinks file will be created.
>
> Signed-off-by: Yufen Yu <yuyufen@huawei.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

-- 
Ming


      parent reply	other threads:[~2021-06-10  6:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  9:27 Yufen Yu
2021-06-08 10:08 ` Jan Kara
2021-06-08 17:10 ` Christoph Hellwig
2021-06-08 21:08 ` Jens Axboe
2021-06-10  2:30   ` Yufen Yu
2021-06-10  6:28 ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFj5m9K1Psc91zvNipb+PKp+zDeFjOKCu+rv3EC9H+1M8gPKiw@mail.gmail.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=hare@suse.de \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=yuyufen@huawei.com \
    --subject='Re: [PATCH] block: check disk exist before trying to add partition' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).