From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888BFC47094 for ; Thu, 10 Jun 2021 06:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C876613CA for ; Thu, 10 Jun 2021 06:28:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbhFJGai (ORCPT ); Thu, 10 Jun 2021 02:30:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21332 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbhFJGah (ORCPT ); Thu, 10 Jun 2021 02:30:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623306521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1FsL/mB1dSHfBUgEK6+GR9cKMoBGx44lVNDr2lSojqA=; b=XXyyjcgaDvPZjwtcWdxE3jO6NW8ZNZeUZaiwdi3/Uba9BdG4KFCr5ScwsGJ7f8MFMgcoDa wRB/KmyYewN+Ij0wRi9otAU4E7EsPnD7a3O9MVEYmZtH38l/f1NFwx41fOpNNnxzpf2wwS 6jb5IPxiGuZH3YZDT59tGpgVkGtT6cg= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-f271hPWBMsCXBuhITk4Rig-1; Thu, 10 Jun 2021 02:28:39 -0400 X-MC-Unique: f271hPWBMsCXBuhITk4Rig-1 Received: by mail-yb1-f197.google.com with SMTP id u48-20020a25ab330000b029053982019c2dso34501062ybi.2 for ; Wed, 09 Jun 2021 23:28:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1FsL/mB1dSHfBUgEK6+GR9cKMoBGx44lVNDr2lSojqA=; b=bRJdDKuyI+/1fGccy6q4HsMhun/WdGsKmJ7Iqy8bUHE8+NwsyiKYu2PE2x0HYYohG/ u5d2XtlHONJbKOo/oTgjeUfHzDbO/a77QypjypTjhp/PAGxtsezamnpL/asaqgP+GiCk 0TN4LY7aIRPwp+GHI1CAFsGi/ds7CoTbnBxkRf8LWPKGqacnP7UAuH5dXK6jcEaZG8tU StnX6akJIfi+whlWeamjddovrIgkVf5CjJRYX1SIxvCZzyDA2cnUGmYhb7ssj+PFnKGg 8yhC89J9OlxDiavM6Q56DXX3C8qCP7VkH+SS4OFzRoAJWrr/E9dsdB+6C/OByVH4S0TR BLQw== X-Gm-Message-State: AOAM531yx/tivhFMEqDT3KGIqXvSbof7qsfthkVDtC+w+ZxEOwocZGSK U3qpyDNVlaZaGN0oF1dNAEGeGnthLqiJukkblqjFOuO3juViVq0UhOG9r0HSt+1uq4EfipKdhGG K6Iiaa6lErxdS30f5RYW41J8bsHPYaVm+nlG3UYw= X-Received: by 2002:a25:bec6:: with SMTP id k6mr5126560ybm.269.1623306519294; Wed, 09 Jun 2021 23:28:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO8FHXlLLlFrK6nyaCQo++y/TWrqTGm/p80DH/RLr6cJerpX48hbVlrbRn4FRYJK8EEE+g9I56KxBq2EfrQRg= X-Received: by 2002:a25:bec6:: with SMTP id k6mr5126550ybm.269.1623306519123; Wed, 09 Jun 2021 23:28:39 -0700 (PDT) MIME-Version: 1.0 References: <20210608092707.1062259-1-yuyufen@huawei.com> In-Reply-To: <20210608092707.1062259-1-yuyufen@huawei.com> From: Ming Lei Date: Thu, 10 Jun 2021 14:28:28 +0800 Message-ID: Subject: Re: [PATCH] block: check disk exist before trying to add partition To: Yufen Yu Cc: Jens Axboe , linux-block@vger.kernel.org, jack@suse.cz, Hannes Reinecke , damien.lemoal@wdc.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jun 8, 2021 at 5:21 PM Yufen Yu wrote: > > If disk have been deleted, we should return fail for ioctl > BLKPG_DEL_PARTITION. Otherwise, the directory /sys/class/block > may remain invalid symlinks file. The race as following: > > blkdev_open > del_gendisk > disk->flags &= ~GENHD_FL_UP; > blk_drop_partitions > blkpg_ioctl > bdev_add_partition > add_partition > device_add > device_add_class_symlinks > > ioctl may add_partition after del_gendisk() have tried to delete > partitions. Then, symlinks file will be created. > > Signed-off-by: Yufen Yu Reviewed-by: Ming Lei -- Ming