From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51B62C04AAA for ; Fri, 3 May 2019 12:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A8592075E for ; Fri, 3 May 2019 12:11:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AR5LhLHk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727240AbfECMLC (ORCPT ); Fri, 3 May 2019 08:11:02 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:34922 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbfECMLC (ORCPT ); Fri, 3 May 2019 08:11:02 -0400 Received: by mail-vk1-f194.google.com with SMTP id t74so1325445vke.2 for ; Fri, 03 May 2019 05:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7EPfuh3wqWjNunrVTrXl5Mg7mVe/Zz2uJJ5OIgeuYU8=; b=AR5LhLHkj5XHdBHZc1L+0PGd1NJocWSFMLdNTCxiykzDIOKW8X3HtX4peKHw57ddcR OF4Ab5Wz7uemC7qkYUwGONSSbirnWvYB0bIn0y+OkfijrwQ93jA+nah8Wyx/uNPDhIhx HuvuYoaUoIdd1cG7xv1c5Y8GMH0JF34RVSpfH9ZvqNZhIgugUHLVxezFIumXj1u1ZOfF aW2SadQXhqzIoNTUfRIh5xWjpWRea6gJXkZHk6kvSWDw+qoEwuzMh+UGY5TQMKTAw6AA cCr1glY/FjBvcx5k/4g3BcdfoVBkOorhUEF38QGjJwEleBi9lmf07XuLd/LFd5/ER7RI JsRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7EPfuh3wqWjNunrVTrXl5Mg7mVe/Zz2uJJ5OIgeuYU8=; b=JKksxmIYvKfGGsRsfpF6aug9JjN/FfDHD4aOxM+FpCW+RFwIWva8b03tmpNEueJpL9 yhaeX0BFb2eVN3j1fniSttpSZ8WmoYcQCRFZSaV5cIWbngWOO65zCgz+qQszxXSI7+8g 0z07NMNkS5CEj8DbCs+IkXTCgKUxoFWDsjJX8NsAm/zSRYV+9vMgFSswWOU0p1+ONRSN 8eLTVW7qOcTS6+fhJXzOl7sNfA8zDXEn2hIsEm3Pmc69QILjoRw+ZDgYeyxvGMDyRywE PzWmqfV/Cl1ubVHWd8OSt4MQMF8FEZxVHsku/ozcS869NN0amSA8JUa6sUyLP88FASkZ u8Qg== X-Gm-Message-State: APjAAAXZKVkMR2R8qTVWInz6siXH7oN9IX1cX2mJInWYdqnIbTHQEe1c 3MujMKZWL+OrRrrcFnQkCt/+ZNDBwLsvRoeu2+WlAA== X-Google-Smtp-Source: APXvYqzb5/HpsLiakHJ0bc9868Ido5gE7o1s7YL8YK01S2J//2fKVnRuiFahuYSr6S1ao0hUwySa4BispzBOfCll7N8= X-Received: by 2002:a1f:7f05:: with SMTP id o5mr5134747vki.91.1556885460996; Fri, 03 May 2019 05:11:00 -0700 (PDT) MIME-Version: 1.0 References: <20190503082819.23112-1-romain.izard.pro@gmail.com> <20190503104227.ga56ffjkrm2gno7h@ws.net.home> In-Reply-To: <20190503104227.ga56ffjkrm2gno7h@ws.net.home> From: Romain Izard Date: Fri, 3 May 2019 14:10:49 +0200 Message-ID: Subject: Re: [PATCH] lib/loopdev.c: Retry LOOP_SET_STATUS64 on EAGAIN To: Karel Zak Cc: util-linux@vger.kernel.org, linux-block@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Le ven. 3 mai 2019 =C3=A0 12:42, Karel Zak a =C3=A9crit : > > On Fri, May 03, 2019 at 10:28:19AM +0200, Romain Izard wrote: > > + do { > > + err =3D ioctl(dev_fd, LOOP_SET_STATUS64, &lc->info); > > + } while (err && errno =3D=3D EAGAIN); > > Would be better to use any delay in the loop? For example after > EAGAIN read/write we use usleep(250000). As we are waiting for the kernel to do some cleanup, this is a good idea. It seems to reduce the need for retries in my use case. I will add this in a v2. Best regards, --=20 Romain Izard