linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yi Zhang <yi.zhang@redhat.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	linux-block <linux-block@vger.kernel.org>,
	Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V3 0/2] block: fix race between adding wbt and normal IO
Date: Thu, 10 Jun 2021 08:45:43 +0800	[thread overview]
Message-ID: <CAHj4cs-dmHwkbWrn7aH18GvxE3t+eqK9HMLMbmuSALyGOP_WnQ@mail.gmail.com> (raw)
In-Reply-To: <20210609015822.103433-1-ming.lei@redhat.com>

Thanks for the fix.

Tested-by: Yi Zhang <yi.zhang@redhat.com>

On Wed, Jun 9, 2021 at 9:58 AM Ming Lei <ming.lei@redhat.com> wrote:
>
> Hello,
>
> Yi reported several kernel panics on:
>
> [16687.001777] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008
> ...
> [16687.163549] pc : __rq_qos_track+0x38/0x60
>
> or
>
> [  997.690455] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020
> ...
> [  997.850347] pc : __rq_qos_done+0x2c/0x50
>
> Turns out it is caused by race between adding wbt and normal IO.
>
> Fix the issue by freezing request queue when adding/deleting rq qos.
>
> V3:
>         - use ->queue_lock for protecting concurrent adding/deleting rqos on
>           same queue
>
> V2:
>         - switch to the approach of freezing queue, which is more generic
>           than V1.
>
>
>
> Ming Lei (2):
>   block: fix race between adding/removing rq qos and normal IO
>   block: mark queue init done at the end of blk_register_queue
>
>  block/blk-rq-qos.h | 24 ++++++++++++++++++++++++
>  block/blk-sysfs.c  | 29 +++++++++++++++--------------
>  2 files changed, 39 insertions(+), 14 deletions(-)
>
> Cc: Yi Zhang <yi.zhang@redhat.com>
> Cc: Bart Van Assche <bvanassche@acm.org>
> --
> 2.31.1
>


-- 
Best Regards,
  Yi Zhang


  parent reply	other threads:[~2021-06-10  0:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  1:58 Ming Lei
2021-06-09  1:58 ` [PATCH V3 1/2] block: fix race between adding/removing rq qos " Ming Lei
2021-06-09 20:05   ` Bart Van Assche
2021-06-09  1:58 ` [PATCH V3 2/2] block: mark queue init done at the end of blk_register_queue Ming Lei
2021-06-09 20:09   ` Bart Van Assche
2021-06-10  0:45 ` Yi Zhang [this message]
2021-06-14 21:55 ` [PATCH V3 0/2] block: fix race between adding wbt and normal IO Ming Lei
2021-06-16 14:11   ` Ming Lei
2021-06-16 14:42 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHj4cs-dmHwkbWrn7aH18GvxE3t+eqK9HMLMbmuSALyGOP_WnQ@mail.gmail.com \
    --to=yi.zhang@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --subject='Re: [PATCH V3 0/2] block: fix race between adding wbt and normal IO' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).