From: Yi Zhang <yi.zhang@redhat.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com
Subject: Re: [PATCH 0/3] block: keep quiesce & unquiesce balanced for scsi/dm
Date: Mon, 25 Oct 2021 09:43:57 +0800 [thread overview]
Message-ID: <CAHj4cs8QB7QCc7t+bweesdZPOLmAXrwrj8yEnAtJPk80L_v1kQ@mail.gmail.com> (raw)
In-Reply-To: <20211021145918.2691762-1-ming.lei@redhat.com>
Verified with the blktests srp/, thanks Ming.
Tested-by: Yi Zhang <yi.zhang@redhat.com>
On Thu, Oct 21, 2021 at 11:00 PM Ming Lei <ming.lei@redhat.com> wrote:
>
> Hello Jens,
>
> Recently we merge the patch of e70feb8b3e68 ("blk-mq: support concurrent queue
> quiesce/unquiesce") for fixing race between driver and block layer wrt.
> queue quiesce.
>
> Yi reported that srp/002 is broken with this patch, turns out scsi and
> dm don't keep the two balanced actually.
>
> So fix dm and scsi and make srp/002 pass again.
>
>
> Ming Lei (3):
> scsi: avoid to quiesce sdev->request_queue two times
> scsi: make sure that request queue queiesce and unquiesce balanced
> dm: don't stop request queue after the dm device is suspended
>
> drivers/md/dm.c | 10 ------
> drivers/scsi/scsi_lib.c | 70 ++++++++++++++++++++++++++------------
> include/scsi/scsi_device.h | 1 +
> 3 files changed, 49 insertions(+), 32 deletions(-)
>
> --
> 2.31.1
>
--
Best Regards,
Yi Zhang
next prev parent reply other threads:[~2021-10-25 1:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 14:59 [PATCH 0/3] block: keep quiesce & unquiesce balanced for scsi/dm Ming Lei
2021-10-21 14:59 ` [PATCH 1/3] scsi: avoid to quiesce sdev->request_queue two times Ming Lei
2021-10-21 14:59 ` [PATCH 2/3] scsi: make sure that request queue queiesce and unquiesce balanced Ming Lei
2021-11-02 1:43 ` James Bottomley
2021-11-02 12:58 ` Ming Lei
2021-11-02 12:59 ` Jens Axboe
2021-11-02 14:33 ` James Bottomley
2021-11-02 14:36 ` Jens Axboe
2021-11-02 14:41 ` Jens Axboe
2021-11-02 14:47 ` James Bottomley
2021-11-02 14:49 ` Jens Axboe
2021-11-02 14:52 ` Jens Axboe
2021-10-21 14:59 ` [PATCH 3/3] dm: don't stop request queue after the dm device is suspended Ming Lei
2021-11-01 16:56 ` Mike Snitzer
2021-10-25 1:43 ` Yi Zhang [this message]
2021-11-01 19:54 ` [PATCH 0/3] block: keep quiesce & unquiesce balanced for scsi/dm Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHj4cs8QB7QCc7t+bweesdZPOLmAXrwrj8yEnAtJPk80L_v1kQ@mail.gmail.com \
--to=yi.zhang@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).