archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <>
To: Steffen Maier <>
Cc: "James E . J . Bottomley" <>,
	"Martin K . Petersen" <>,
	Doug Gilbert <>,
	linux-scsi <>,
	linux-s390 <>,
	Benjamin Block <>,
	Heiko Carstens <>,
	Vasily Gorbik <>,
	"" <>,
	Jens Axboe <>, Al Viro <>,
	Linux FS-devel Mailing List <>,
	Chaitanya Kulkarni <>,
	Thomas Gleixner <>,
	Mauro Carvalho Chehab <>,
	Omar Sandoval <>,
	linux-block <>,
	Linux-Next Mailing List <>,
	Mark Brown <>,
Subject: Re: [PATCH] compat_ioctl: fix reimplemented SG_IO handling causing -EINVAL from sg_io()
Date: Wed, 9 Oct 2019 18:01:29 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Sep 18, 2019 at 5:35 PM Steffen Maier <> wrote:
> scsi_cmd_ioctl() had hdr as on stack auto variable and called
> copy_{from,to}_user with the address operator &hdr and sizeof(hdr).
> After the refactoring, {get,put}_sg_io_hdr() takes a pointer &hdr.
> So the copy_{from,to}_user within the new helper functions should
> just take the given pointer argument hdr and sizeof(*hdr).
> I saw -EINVAL from sg_io() done by /usr/lib/udev/scsi_id which could
> in turn no longer whitelist SCSI disks for devicemapper multipath.
> Signed-off-by: Steffen Maier <>
> Fixes: 4f45155c29fd ("compat_ioctl: reimplement SG_IO handling")
> ---
> Arnd, I'm not sure about the sizeof(hdr32) change in the compat part in
> put_sg_io_hdr().
> This is for next, probably via Arnd's y2038/y2038,
> and it fixes next-20190917 for me regarding SCSI generic.

Hi Steffen,

Sorry for the long delay. I ended up not sending my pull request for
v5.4, so the bug is not there. I have now rebased my branch
on top of v5.4-rc2 and plan to send it for the v5.5 merge window.

I have folded your bugfix into my original patch, hope that's ok with
you. Tomorrow's linux-next should be fixed.


      reply	other threads:[~2019-10-09 16:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18 15:34 [PATCH] compat_ioctl: fix reimplemented SG_IO handling causing -EINVAL from sg_io() Steffen Maier
2019-10-09 16:01 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).