From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570D1C55178 for ; Thu, 29 Oct 2020 19:34:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED9D320838 for ; Thu, 29 Oct 2020 19:34:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qyAdMLTe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbgJ2TeX (ORCPT ); Thu, 29 Oct 2020 15:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbgJ2TeR (ORCPT ); Thu, 29 Oct 2020 15:34:17 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B516C0613CF for ; Thu, 29 Oct 2020 12:34:17 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id w11so1781953pll.8 for ; Thu, 29 Oct 2020 12:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=no+LFVggH1X+W4BzHVXAaNv+yc1wDOUghNOGzIROf18=; b=qyAdMLTeSzMhaaJK2dlID6/WegSaP74cbynv9ImzQ7d9/yD0hRd28az42zcogXLTBe VoibyEkl4eBzDPG6Qri1M90Ztr30Z6kpQ/mHOigSAnQ8k417FY4JBi9H4Vsud8gdAb9o r3YOcpUdgbbjBQfPfCAwKTfcFOFgYgshfqD72mwHRBNwGv9BGt8Bg5iKJLx2vdkDPQLm jpgnzaQWvOvP9x6pFSKitmFpaPpP/v0eFHphKxlwDfU7Sap3VrnMzHoVZkNg9+Fu6CPU M19p7c+nfwT4f9G21BOCNAgcZhDKLhWFwC3WVUenZhs0P3W2puUfgkk3eP050WLRT6bY lxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=no+LFVggH1X+W4BzHVXAaNv+yc1wDOUghNOGzIROf18=; b=oy6P6E9/Ma5T2tDXVYwsC3UTfyUyAVnA8rWSG7FnrSQXxERoHW0s6ta3suTJ64jUcH zL6nRVy2SwZ6x9ANfleDMR33iQ4jXUFNE2NfyMmiVNtD8KpNfGWTMOqgxyggm/V/GMOm 14OzMACxICOaZkWMx8elXSvz1ePCundNnOQM15YTd/rVBJkR2dTvYeYR8ac09o3yGUkS QQjjC9VWCw5smji4dyKkunp+rV2HbANlMSMqAwTtxJJtH1XDKTgzA5IjZgg/kGFQoeUZ a9fk81HgAt/P29bo8PyDX2oPFxCuziw6YiEK/jG2zAmnZoFh/71aEzrTi1DdN59xsDYE oSzA== X-Gm-Message-State: AOAM530Ck+4RQipkW5/UrQeYHBCC8iz4YLWwFr0PnjHqXj0H8bjN0LVu 7la9kEcJKZ5nk6t39dQoM1w6nPdMl0aRPLXXLno/ZA== X-Google-Smtp-Source: ABdhPJyLa39Lok2TGDOrhjed0bxZPeqYmMk2y5AOr/vIOxrVDWaZbltVNWvL9dGnOEjpsdSas6FDn2Ip07nV138ZTWE= X-Received: by 2002:a17:902:8ecc:b029:d6:991d:1193 with SMTP id x12-20020a1709028eccb02900d6991d1193mr1428555plo.56.1604000056830; Thu, 29 Oct 2020 12:34:16 -0700 (PDT) MIME-Version: 1.0 References: <20201026213040.3889546-1-arnd@kernel.org> <20201026213040.3889546-3-arnd@kernel.org> In-Reply-To: <20201026213040.3889546-3-arnd@kernel.org> From: Nick Desaulniers Date: Thu, 29 Oct 2020 12:34:05 -0700 Message-ID: Subject: Re: [PATCH net-next 03/11] rsxx: remove extraneous 'const' qualifier To: Arnd Bergmann Cc: Joshua Morris , Philip Kelleher , Arnd Bergmann , Jens Axboe , Nathan Chancellor , "Gustavo A. R. Silva" , Bjorn Helgaas , linux-block@vger.kernel.org, LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Oct 26, 2020 at 2:31 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The returned string from rsxx_card_state_to_str is 'const', > but the other qualifier doesn't change anything here except > causing a warning with 'clang -Wextra': > > drivers/block/rsxx/core.c:393:21: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] > static const char * const rsxx_card_state_to_str(unsigned int state) > > Fixes: f37912039eb0 ("block: IBM RamSan 70/80 trivial changes.") > Signed-off-by: Arnd Bergmann Reviewed-by: Nick Desaulniers > --- > drivers/block/rsxx/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c > index 63f549889f87..d0af46d7b681 100644 > --- a/drivers/block/rsxx/core.c > +++ b/drivers/block/rsxx/core.c > @@ -390,7 +390,7 @@ static irqreturn_t rsxx_isr(int irq, void *pdata) > } > > /*----------------- Card Event Handler -------------------*/ > -static const char * const rsxx_card_state_to_str(unsigned int state) > +static const char *rsxx_card_state_to_str(unsigned int state) > { > static const char * const state_strings[] = { > "Unknown", "Shutdown", "Starting", "Formatting", > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers