Re: [PATCH v5 02/25] rtrs: public interface header to establish RDMA connections

From: Jinpu Wang <jinpu.wang@cloud.ionos.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
	Jack Wang <jinpuwang@gmail.com>,
	linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Bart Van Assche <bvanassche@acm.org>,
	Doug Ledford <dledford@redhat.com>,
	rpenyaev@suse.de
Subject: Re: [PATCH v5 02/25] rtrs: public interface header to establish RDMA connections
Date: Mon, 23 Dec 2019 11:31:28 +0100	[thread overview]
Message-ID: <CAMGffEk_3QYzj6MoSh_06fmvJzvv5qLKJXJ3d-m4oQRhH5ZyGg@mail.gmail.com> (raw)
In-Reply-To: <20191223080438.GL13335@unreal>

On Mon, Dec 23, 2019 at 9:04 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Mon, Dec 23, 2019 at 08:38:54AM +0100, Jinpu Wang wrote:
> > On Sun, Dec 22, 2019 at 8:36 AM Leon Romanovsky <leon@kernel.org> wrote:
> > >
> > > On Sat, Dec 21, 2019 at 03:27:55PM +0100, Danil Kipnis wrote:
> > > > Hi Leon,
> > > >
> > > > On Sat, Dec 21, 2019 at 11:15 AM Leon Romanovsky <leon@kernel.org> wrote:
> > > > >
> > > > > Perhaps it is normal practice to write half a company as authors,
> > > > > and I'm wrong in the following, but code authorship is determined by
> > > > > multiple tags in the commit messages.
> > > >
> > > > Different developers contributed to the driver over the last several
> > > > years. Currently they are not working any more on this code. What tags
> > > > in the commit message do you think would be appropriate to give those
> > > > people credit for their work?
> > >
> > > Signed-of-by/Co-developed-../e.t.c
> > >
> > > But honestly without looking in your company contract, I'm pretty sure
> > > that those people are not eligible for special authorship rights and
> > > credits beyond already payed by the employer.
> > >
> > Hi, Leon,
> >
> > Thanks for the suggestion, how about only remove the authors for the
> > new entry, only keep the company copyright?
> > > +/* Copyright (c) 2019 1&1 IONOS SE. All rights reserved.
> > > + * Authors: Jack Wang <jinpu.wang@cloud.ionos.com>
> > > + *          Danil Kipnis <danil.kipnis@cloud.ionos.com>
> > > + *          Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
> > > + *          Lutz Pogrell <lutz.pogrell@cloud.ionos.com>
> > > + */
> >
> > The older entries were there, I think it's not polite to remove them.
>
> From our point of view, this is brand new code and it doesn't matter how
> many internal iterations you had prior submission. If you want to be
> polite, your company shall issue official press release and mention
> all those names there as main contributors for RTRS success.
>
> You can find a lot of examples of "Authors:" in the kernel code, but
> they one of two: code from pre-git era or copy/paste multiplied by
> cargo cult.
>
> Thanks
>
Ok, will only keep the copyright lines, and remove Authors.

Thanks