From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D4EC2D0EF for ; Tue, 31 Mar 2020 07:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8973120781 for ; Tue, 31 Mar 2020 07:11:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="Syt6I7b4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726622AbgCaHL6 (ORCPT ); Tue, 31 Mar 2020 03:11:58 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:41113 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726174AbgCaHL6 (ORCPT ); Tue, 31 Mar 2020 03:11:58 -0400 Received: by mail-io1-f67.google.com with SMTP id b12so4406190ion.8 for ; Tue, 31 Mar 2020 00:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dyIJAxsjyPfo63pYnLLVkVMuMntd+Bvgnj1mH36dLJ8=; b=Syt6I7b4VQq7iQoFWq653jEF4HP3jGalh2TTNhbJ/ZM3hQvoYzOhMvsJCcxKyPUFOd i78Qc2IksCvl763wS40XCJVPrNvCf9y+l5GOL0PQSvCq0xi6SzfrVB/+ZY4MMSuAGrLt rqaIdr6lq/H5lLSrpiXpY4bFrgnNrqC7HNiiyTPaBGvrfMGlBnDQECXJbcDs6jGKnR3E qtZCKd8YsCJVE8U0S7Htve7fGp/Bnqwj9ULbpiZbcwycYCky7e5zW4TmsiYsAk4vNzgc GmBvSPxsbVRANypgVgToecOb/dSwlrW87Gbh28EYqjG+1NGjqEn55l7sxeGOsdDnzDi9 YNgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dyIJAxsjyPfo63pYnLLVkVMuMntd+Bvgnj1mH36dLJ8=; b=WWd8c3bz7TzK8F53MfSQHB7V+C+8ma5F7u1L4cedHzg/IQepRUw2+aLUQJtDSPQK9h vLeQpj1nWtPLeovYwhPG4ip3MyZsblZOcvtAIC6QANOIMXLlsFk1GLs2SuudEp0VeSW8 42vGGW5rOYocK18pO6Ge3Fq1+NmbaOavK2dqp6UGzwn9YdyhQpl9ZeowIXkWINqTNRKa R2E4JzvW/wdFfi2r3nbx4d/eEDlhJ5exeTjgpjECjU43PjK07jolLuNTq+8J/Nj8pkuA picF1WXoN0t52HmRBUICKHLJfM9QKDAioo6ZcC3tYGIzbVSUsN8J/IosYEXAMIjuWwbo /WPg== X-Gm-Message-State: ANhLgQ2SLm1aXnqaIx8UOXFVm8iZfTZ7PZvnVF90efforQRuHmxR0MLC jhlck/2vjwp1g3z3ZUu8SX9PCCcMYxLmablofWU0qA== X-Google-Smtp-Source: ADFU+vtOl83nx67ab+nsIcYc5sPzd/+sz8Z+61pXzG3C64h7OIrqxepFtqNasJjQAzXhLSGn0T6lLVu5Hz2BMIRCCgc= X-Received: by 2002:a05:6638:a99:: with SMTP id 25mr15018322jas.37.1585638717499; Tue, 31 Mar 2020 00:11:57 -0700 (PDT) MIME-Version: 1.0 References: <20200320121657.1165-1-jinpu.wang@cloud.ionos.com> <20200320121657.1165-5-jinpu.wang@cloud.ionos.com> <445d2545-de0e-3ca5-4a6a-97c00de6f117@acm.org> In-Reply-To: <445d2545-de0e-3ca5-4a6a-97c00de6f117@acm.org> From: Jinpu Wang Date: Tue, 31 Mar 2020 09:11:46 +0200 Message-ID: Subject: Re: [PATCH v11 04/26] RDMA/rtrs: core: lib functions shared between client and server modules To: Bart Van Assche Cc: linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Doug Ledford , Jason Gunthorpe , Danil Kipnis , Roman Penyaev , Pankaj Gupta Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 31, 2020 at 12:25 AM Bart Van Assche wrote: > > On 2020-03-30 03:34, Jinpu Wang wrote: > > On Sat, Mar 28, 2020 at 5:26 AM Bart Van Assche wrote: > >> On 2020-03-20 05:16, Jack Wang wrote: > >>> +/** > >>> + * rtrs_addr_to_sockaddr() - convert path string "src,dst" to sockaddreses > >>> + * @str: string containing source and destination addr of a path > >>> + * separated by comma. I.e. "ip:1.1.1.1,ip:1.1.1.2". If str > >>> + * contains only one address it's considered to be destination. > >>> + * @len: string length > >>> + * @port: will be set to port. > >> ^^^^^^^^^^^^^^^^^^^ > >> What does this mean? Please make comments easy to comprehend. > > how about just "port number"? > > I don't think that's enough information. How about "destination port > number"? Sounds better, thank you!