Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
From: Jinpu Wang <jinpu.wang@ionos.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Md Haris Iqbal <haris.iqbal@ionos.com>,
	linux-block <linux-block@vger.kernel.org>,
	Danil Kipnis <danil.kipnis@ionos.com>
Subject: Re: [PATCH V6 0/3] block: add two statistic tables
Date: Mon, 19 Apr 2021 08:37:43 +0200
Message-ID: <CAMGffEmVhXepdmMJcb6F2jYOqO8OGgS0xeuUXpLPcWh+r1RxiA@mail.gmail.com> (raw)
In-Reply-To: <CAMGffE=ZdCUc_HABY3_F_aK6pqCt8maB4yi9Qu4gKoox6ub6QQ@mail.gmail.com>

On Mon, Apr 12, 2021 at 7:35 AM Jinpu Wang <jinpu.wang@ionos.com> wrote:
>
> On Fri, Apr 9, 2021 at 11:03 PM Jens Axboe <axboe@kernel.dk> wrote:
> >
> > On 4/9/21 10:03 AM, Md Haris Iqbal wrote:
> > > Hi Jens,
> > >
> > > This version fixes the long lines in the code as per Christoph's comment.
> >
> > I'd really like to see some solid justification for the addition,
> > though. I clicked the v1 link and it's got details on what you get out
> > of it, but not really the 'why' of reasoning for the feature. I mean,
> > you could feasibly have a blktrace based userspace solution. Just
> > wondering if that has been tried, I know that's what we do at Facebook
> > for example.
> >
> Hi Jens,
>
> Thanks for the reply.
> For the use case of the additional stats, as a cloud provider, we
> often need to handle report from the customers regarding
> performance problem in a period of time in the past, so it's not
> feasible for us to run blktrace, customer workload could change from
> time to time, with the additional stats, we gather through all metrics
> using Prometheus, we can navigate to the period of time interested,
> to check if the performance matches the SLA, it also helps us to find
> the user IO pattern,  we can more easily reproduce.
>
> We do use blktrace from time to time too if it's not too late (when IO
> pattern has not changed.)
>
> Thanks!
> Jack

Hi Jens,

A gentle ping!

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 16:03 Md Haris Iqbal
2021-04-09 16:03 ` [PATCH V6 1/3] block: add io_extra_stats node Md Haris Iqbal
2021-04-09 16:03 ` [PATCH V6 2/3] block: add a statistic table for io latency Md Haris Iqbal
2021-04-09 16:03 ` [PATCH V6 3/3] block: add a statistic table for io sector Md Haris Iqbal
2021-04-09 21:03 ` [PATCH V6 0/3] block: add two statistic tables Jens Axboe
2021-04-12  5:35   ` Jinpu Wang
2021-04-19  6:37     ` Jinpu Wang [this message]
2021-04-19 17:57     ` Jens Axboe
2021-04-21  7:49       ` Jinpu Wang
2021-04-21 10:20         ` Pavel Begunkov
2021-04-21 11:50           ` Jinpu Wang
2021-04-21 11:55             ` Pavel Begunkov
2021-04-21 11:57               ` Jinpu Wang
2021-04-21 17:02                 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMGffEmVhXepdmMJcb6F2jYOqO8OGgS0xeuUXpLPcWh+r1RxiA@mail.gmail.com \
    --to=jinpu.wang@ionos.com \
    --cc=axboe@kernel.dk \
    --cc=danil.kipnis@ionos.com \
    --cc=haris.iqbal@ionos.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git