From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04FEC33CB6 for ; Thu, 16 Jan 2020 14:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A40302087E for ; Thu, 16 Jan 2020 14:54:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="Kj7gutjs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728905AbgAPOyQ (ORCPT ); Thu, 16 Jan 2020 09:54:16 -0500 Received: from mail-il1-f177.google.com ([209.85.166.177]:38582 "EHLO mail-il1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgAPOyP (ORCPT ); Thu, 16 Jan 2020 09:54:15 -0500 Received: by mail-il1-f177.google.com with SMTP id f5so18342959ilq.5 for ; Thu, 16 Jan 2020 06:54:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xgyrYhMa/wdaQL5Cirrm7tGJXmXbD7bkOwfd7E43Rds=; b=Kj7gutjsLQ9UYZab36H6F+NHFFAsQkxciYGdVs3cFH+orpWwywG0KyGxIqVmMAhOpX YbTZcNryMnySNqvrxcbxLdDvI/osaNurfoQ5TdIJbBpueF35looQO/rr4vrf1VIawNs8 N8g0Bt5zfnPyf9Xwx0I0G76FwbEF1yZheZF6Ip2WE7lMtddkBKO12fu9JPFdAET2Iyzk Z0Ugn5F/FlcciueVm9qb4Ac78IYBPfQj74E1Snl4DisX8tLCV6jcxI9LDhYIJ15ZeQ2r kha2cySOqQXVkmZBC60bV/B8BHzW7ofIvlnYLuLI1Xj/Da8sJ3qrphmvyfM1uk+I0hpE 7CCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xgyrYhMa/wdaQL5Cirrm7tGJXmXbD7bkOwfd7E43Rds=; b=GVy3deSBhwVqozza4A7P8lJfrn09GZLANJqjbdyj1gvZ0cRhIAUvWQefmDR3JgpR9S WmGbPTlzSWkIeWmg72k+h9mnLLKiRRrOIhvhP5gIAVCrMblw1YfAmnCQucy1s/ygc4tN zAZlQDeJk3JUHoXp5pINPo4jYUPC9g5BsL3UbmKkjoSisCE/0NAYiRrn1T7U9V3u30n9 nNvmIm4XPJFpqf4gz1r4yGXgeyv6gcpOUDKvLXvp5AxMJZjM4ru8euu0kvQq+/7l10x5 RiINJaeA00qloeZvU+Cm07Q1xGUSBtOyetSwdb6mpnszBZ3ZWfUoR+2Lrb144K7iqS1/ OI3w== X-Gm-Message-State: APjAAAVNn9OCjL40TYZNuBUFuc/iBTAjLgRrmlBYN+bbLw+HUTCDpg14 SvPdEe295AwHbVUFFOKVxSnja17eP5y9zCOqg//RGw== X-Google-Smtp-Source: APXvYqzZHU1h+bHJy82S0s84ODkMbsXPrH1P3QeL5kMpJfkw63uJD8hB+9QzZr722BOZo+K6QQhfurlHZ3ZFW25DlfM= X-Received: by 2002:a05:6e02:f0f:: with SMTP id x15mr3665714ilj.298.1579186454960; Thu, 16 Jan 2020 06:54:14 -0800 (PST) MIME-Version: 1.0 References: <20200116125915.14815-1-jinpuwang@gmail.com> <20200116125915.14815-24-jinpuwang@gmail.com> <20200116144005.GB12433@unreal> In-Reply-To: <20200116144005.GB12433@unreal> From: Jinpu Wang Date: Thu, 16 Jan 2020 15:54:03 +0100 Message-ID: Subject: Re: [PATCH v7 23/25] block/rnbd: include client and server modules into kernel compilation To: Leon Romanovsky Cc: Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Bart Van Assche , Doug Ledford , Jason Gunthorpe , Danil Kipnis , Roman Penyaev Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > > +obj-$(CONFIG_BLK_DEV_RNBD_CLIENT) += rnbd-client.o > > +obj-$(CONFIG_BLK_DEV_RNBD_SERVER) += rnbd-server.o > > + > > +-include $(src)/compat/compat.mk > > What is it? > > Thanks quote from Roman "' Well, in our production we use same source code and in order not to spoil sources with 'ifdef' macros for different kernel versions we use compat layer, which obviously will never go upstream. This line is the only clean way to keep sources always up-to-date with latest kernel and still be compatible with what we have on our servers in production. '-' prefix at the beginning of the line tells make to ignore it if file does not exist, so should not rise any error for compilation against latest kernel. Here is an example of the compat layer for RNBD block device: https://github.com/ionos-enterprise/ibnbd/tree/master/rnbd/compat "' We will remove it also the one in the makefile for rtrs if we need to send another round. Thanks