From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1360CC2D0E8 for ; Tue, 31 Mar 2020 07:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF3B820781 for ; Tue, 31 Mar 2020 07:21:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="GTEMTjOK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbgCaHVB (ORCPT ); Tue, 31 Mar 2020 03:21:01 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:44989 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgCaHVB (ORCPT ); Tue, 31 Mar 2020 03:21:01 -0400 Received: by mail-io1-f66.google.com with SMTP id r25so8806454ioc.11 for ; Tue, 31 Mar 2020 00:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=52yap1u5QwMRqsrXFtOjtT2B5QyIT4tucmUPphiOHrI=; b=GTEMTjOKXFybxlRKumEuM4V/PfF6eBoKtww0OsO9YQzyVAdmrNJggQ9yvKE3ewczqJ F+jPdYQ3iOHbUnaKd5ChLHGybOJzcn5KN9BElQ8ELug4liXs5Deb1SnBHz0eh7KmudSC qAB58ESePxjulAy6d3OajZ3wwhsnemHu/wSAtrk6kIu0VVzJN4CN93CPwecH1RwZfRak Ak7V7rGQCPkXfNVvBD2cJyMedHJS93EzOT4liUhD0/bHf0cPG+CIru100SXDPHjlvnLm 9zi/m/0Td1R6AWxbb5CEkSR+rHvnYLP414D8r8PpT8jXhFEKU9D7vxR//2MBRfgl7EEK ITjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=52yap1u5QwMRqsrXFtOjtT2B5QyIT4tucmUPphiOHrI=; b=uQMBZVADPdFKWdYI+eLybceFyP1BDyx0eM1dHh2L1PwhcK3QOu/mg0k7tGwbmftRIo G6C8KGmJnrRGUVeE/uVlX25mNnrKzyYbR0ZrpgVAd90RfR7Y4r+Zt07/ueors5LvojjG AKk2ihemhZ0mol9yJdd22hlXuclsPQbeRh4v4ZLuXmjeLl68XgrOlZJrPJ9aa/VXSuZR cznPy3eTxrlMuZ+7kUHg3JWWe6gqsMcb8Z2hbsq866JzJPZSrCB8KJEnPLIzblEKbMGm 3280BS137t6lmekXfmVypS9FYdFm82IWHAdPr20uTocUQwQkueU6l4zIPL3EcznBPHP9 Y/kw== X-Gm-Message-State: ANhLgQ1qAZUY1GxGYfaw4AnDhFvjIweXnaVsshMk4VcMQjWfTLAvqfES 7GHFArpn+OoqGD7p5uJHlzc/7X5U6fsm4njS/iabiQ== X-Google-Smtp-Source: ADFU+vsGLU/X7G6MrKpVK698XftSrAYv6eZQKIXo1zyQm2wQUl+il0qTmzzzZLjZ6UV6oJNrdPigOZINLrNoZWrkQJg= X-Received: by 2002:a6b:2d7:: with SMTP id 206mr14110250ioc.42.1585639260339; Tue, 31 Mar 2020 00:21:00 -0700 (PDT) MIME-Version: 1.0 References: <20200320121657.1165-1-jinpu.wang@cloud.ionos.com> <20200320121657.1165-9-jinpu.wang@cloud.ionos.com> <788b815a-913b-5e4e-4023-585407411b5b@acm.org> In-Reply-To: <788b815a-913b-5e4e-4023-585407411b5b@acm.org> From: Jinpu Wang Date: Tue, 31 Mar 2020 09:20:49 +0200 Message-ID: Subject: Re: [PATCH v11 08/26] RDMA/rtrs: client: sysfs interface functions To: Bart Van Assche Cc: linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Doug Ledford , Jason Gunthorpe , Danil Kipnis , Roman Penyaev , Pankaj Gupta Content-Type: text/plain; charset="UTF-8" Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 31, 2020 at 12:28 AM Bart Van Assche wrote: > > On 2020-03-20 05:16, Jack Wang wrote: > > +static struct kobj_type ktype = { > > + .sysfs_ops = &kobj_sysfs_ops, > > +}; > > A release method is missing - please fix this. > > Thanks, > > Bart. Sure, will fix it. Thanks Bart!