linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zheyu Ma <zheyuma97@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, liushixin2@huawei.com,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lee Jones <lee.jones@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	guoqing.jiang@cloud.ionos.com, linux-block@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: mtip32xx: set the pointer of queue to null after cleaning
Date: Mon, 21 Jun 2021 15:50:28 +0800	[thread overview]
Message-ID: <CAMhUBj=OH8TOtVrJSfStWT=YWr3=Od=D+-BCtGhX1nN76wOYDA@mail.gmail.com> (raw)
In-Reply-To: <YNAupxssJ/6zNyln@infradead.org>

On Mon, Jun 21, 2021 at 2:16 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Sun, Jun 20, 2021 at 12:19:17PM +0000, Zheyu Ma wrote:
> > When 'mtip_block_initialize' fails at 'mtip_hw_get_identify', a series
> > of cleanup operations will be performed. But when the execution reaches
> > 'put_disk', it will cause refcount underflow. The reason for this error
> > is that after cleaning 'dd->queue', 'dd->disk->queue' was not set to
> > null at the same time, which caused repeated cleanup work.
> >
> > Fix this by set 'dd->disk->queue' to null after cleaning
>
> This should all be fixed by the switch to blk_cleanup_disk and the
> preparation for it in linux-next.

Thanks for your reply, I have switched to the linux-next branch.

Best regards,
Zheyu Ma

      reply	other threads:[~2021-06-21  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 12:19 [PATCH] block: mtip32xx: set the pointer of queue to null after cleaning Zheyu Ma
2021-06-21  6:16 ` Christoph Hellwig
2021-06-21  7:50   ` Zheyu Ma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMhUBj=OH8TOtVrJSfStWT=YWr3=Od=D+-BCtGhX1nN76wOYDA@mail.gmail.com' \
    --to=zheyuma97@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=guoqing.jiang@cloud.ionos.com \
    --cc=hch@infradead.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liushixin2@huawei.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).