From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Sender: geert.uytterhoeven@gmail.com In-Reply-To: References: <20180514184634.2160-1-bart.vanassche@wdc.com> <20180514184634.2160-2-bart.vanassche@wdc.com> From: Geert Uytterhoeven Date: Mon, 14 May 2018 23:23:26 +0200 Message-ID: Subject: Re: [PATCH v9 1/2] arch/*: Add CONFIG_ARCH_HAVE_CMPXCHG64 To: Bart Van Assche Cc: "jcmvbkbc@gmail.com" , "schwidefsky@de.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "tglx@linutronix.de" , "deller@gmx.de" , "heiko.carstens@de.ibm.com" , "hch@lst.de" , "fenghua.yu@intel.com" , "axboe@kernel.dk" , "hpa@zytor.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "mingo@redhat.com" , "jejb@parisc-linux.org" , "tony.luck@intel.com" , "chris@zankel.net" , "davem@davemloft.net" , "arnd@arndb.de" , "benh@kernel.crashing.org" , "mpe@ellerman.id.au" , "paulus@samba.org" Content-Type: text/plain; charset="UTF-8" List-ID: Hi Bart, On Mon, May 14, 2018 at 10:42 PM, Bart Van Assche wrote: > On Mon, 2018-05-14 at 11:50 -0700, Max Filippov wrote: >> On Mon, May 14, 2018 at 11:46 AM, Bart Van Assche >> wrote: >> > The next patch in this series introduces a call to cmpxchg64() >> > in the block layer core for those architectures on which this >> > functionality is available. Make it possible to test whether >> > cmpxchg64() is available by introducing CONFIG_ARCH_HAVE_CMPXCHG64. >> > >> > --- >> >> [...] >> >> > diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig >> > index c921e8bccdc8..8234278a821d 100644 >> > --- a/arch/xtensa/Kconfig >> > +++ b/arch/xtensa/Kconfig >> > @@ -23,6 +23,7 @@ config XTENSA >> > select HAVE_DMA_CONTIGUOUS >> > select HAVE_EXIT_THREAD >> > select HAVE_FUNCTION_TRACER >> > + select ARCH_HAVE_CMPXCHG64 >> >> This breaks alphabetical sorting of Kconfig entries. > > Hello Max, > > Thanks for the feedback. Do you perhaps know whether keeping names in > alphabetical order is a requirement for arch/xtensa/Kconfig only or > whether this is required for all arch/*/Kconfig files? It's a good practice anyway, as it reduces the probability of merge conflicts. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds