From: Roman Stratiienko <roman.stratiienko@globallogic.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-kernel@vger.kernel.org, nbd@other.debian.org,
Aleksandr Bulyshchenko <A.Bulyshchenko@globallogic.com>,
linux-block@vger.kernel.org, axboe@kernel.dkn.org
Subject: Re: [PATCH 2/2] nbd: add support for nbd as root device
Date: Thu, 13 Jun 2019 19:21:43 +0300 [thread overview]
Message-ID: <CAODwZ7so4cVVJmPHXGGOxKRO_0L2NjZJac73wfaHPV7ZN6ce1g@mail.gmail.com> (raw)
In-Reply-To: <20190613145535.tdesq3y2xy6ycpw7@MacBook-Pro-91.local>
> I don't doubt you have a good reason to want it, I'm just not clear on why an
> initramfs isn't an option? You have this special kernel with your special
> option, and you manage to get these things to boot your special kernel right?
> So why is a initramfs with a tiny nbd-client binary in there not an option?
>
> Also I mean that there are a bunch of different nbd servers out there. We have
> our own here at Facebook, qemu has one, IIRC there's a ceph one. They all have
> their own connection protocols. The beauty of NBD is that it doesn't have to
> know about that part, it just does the block device part, and I'd really rather
> leave it that way. Thanks,
>
> Josef
The only reason I prefer embed client into the kernel is to save
valuable engineering time creating and supporting custom initramfs,
that is not so easy especially on Android-based systems.
Taking into account that if using NBD and creating custom initramfs
required only for automated testing, many companies would choose
manual deployment instead, that is bad for the human progress.
I believe that all users of non-standard NBD handshake protocols could
continue to use custom nbd-clients.
Either you accept this patch or not I would like to pass review from
maintainers and other persons that was involved in NBD development,
thus making a step closer to get this mainlined in some future.
--
Regards,
Roman
next prev parent reply other threads:[~2019-06-13 16:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 16:31 [PATCH 1/2] nbd: make sock_xmit() and nbd_add_socket() more generic roman.stratiienko
2019-06-12 16:31 ` [PATCH 2/2] nbd: add support for nbd as root device roman.stratiienko
2019-06-13 12:56 ` Eric Blake
2019-06-13 13:02 ` Eric Blake
2019-06-13 13:14 ` Eric Blake
2019-06-13 13:52 ` Josef Bacik
2019-06-13 14:45 ` Roman Stratiienko
2019-06-13 14:55 ` Josef Bacik
2019-06-13 16:21 ` Roman Stratiienko [this message]
2019-06-13 16:54 ` Josef Bacik
2019-06-14 10:33 ` Wouter Verhelst
2019-06-14 13:38 ` Josef Bacik
2019-06-14 21:23 ` Wouter Verhelst
2019-06-13 15:14 ` Eric Blake
2019-06-13 16:05 ` Roman Stratiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAODwZ7so4cVVJmPHXGGOxKRO_0L2NjZJac73wfaHPV7ZN6ce1g@mail.gmail.com \
--to=roman.stratiienko@globallogic.com \
--cc=A.Bulyshchenko@globallogic.com \
--cc=axboe@kernel.dkn.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).