From: Ulf Hansson <ulf.hansson@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Jens Axboe" <axboe@kernel.dk>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"David Heidelberg" <david@ixit.cz>,
"Peter Geis" <pgwipeout@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Nicolas Chauvet" <kwizart@gmail.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Billy Laws" <blaws05@gmail.com>,
"Nils Östlund" <nils@naltan.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Randy Dunlap" <rdunlap@infradead.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
"Andrey Danin" <danindrey@mail.ru>,
"Gilles Grandou" <gilles@grandou.net>,
"Ryan Grachek" <ryan@edited.us>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Steve McIntyre" <steve@einval.com>,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v6 2/7] mmc: block: Add mmc_bdev_to_card() helper
Date: Mon, 18 May 2020 09:24:42 +0200 [thread overview]
Message-ID: <CAPDyKFrGbKSx=afZCNBN_r_6iNm_TX0tZVRLK05ZUTDBGvAuyA@mail.gmail.com> (raw)
In-Reply-To: <7bddacf1-5fe0-5119-48ac-6a0cc65c5af0@gmail.com>
On Mon, 18 May 2020 at 01:55, Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 17.05.2020 05:12, Dmitry Osipenko пишет:
> > NVIDIA Tegra Partition Table takes into account MMC card's BOOT_SIZE_MULT
> > parameter, and thus, the partition parser needs to retrieve that EXT_CSD
> > value from the block device. There are also some other parts of struct
> > mmc_card that are needed for the partition parser in order to calculate
> > the eMMC offset and verify different things. This patch introduces new
> > helper which takes block device for the input argument and returns the
> > corresponding MMC card.
> >
> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > ---
> > drivers/mmc/core/block.c | 15 +++++++++++++++
> > include/linux/mmc/blkdev.h | 13 +++++++++++++
> > 2 files changed, 28 insertions(+)
> > create mode 100644 include/linux/mmc/blkdev.h
> >
> > diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> > index c5367e2c8487..99298e888381 100644
> > --- a/drivers/mmc/core/block.c
> > +++ b/drivers/mmc/core/block.c
> > @@ -40,6 +40,7 @@
> > #include <linux/debugfs.h>
> >
> > #include <linux/mmc/ioctl.h>
> > +#include <linux/mmc/blkdev.h>
> > #include <linux/mmc/card.h>
> > #include <linux/mmc/host.h>
> > #include <linux/mmc/mmc.h>
> > @@ -305,6 +306,20 @@ static ssize_t force_ro_store(struct device *dev, struct device_attribute *attr,
> > return ret;
> > }
> >
> > +struct mmc_card *mmc_bdev_to_card(struct block_device *bdev)
> > +{
> > + struct mmc_blk_data *md;
> > +
> > + if (bdev->bd_disk->major != MMC_BLOCK_MAJOR)
> > + return NULL;
> > +
> > + md = mmc_blk_get(bdev->bd_disk);
> > + if (!md)
> > + return NULL;
> > +
> > + return md->queue.card;
> > +}
> > +
> > static int mmc_blk_open(struct block_device *bdev, fmode_t mode)
> > {
> > struct mmc_blk_data *md = mmc_blk_get(bdev->bd_disk);
> > diff --git a/include/linux/mmc/blkdev.h b/include/linux/mmc/blkdev.h
> > new file mode 100644
> > index 000000000000..67608c58de70
> > --- /dev/null
> > +++ b/include/linux/mmc/blkdev.h
> > @@ -0,0 +1,13 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * linux/include/linux/mmc/blkdev.h
> > + */
> > +#ifndef LINUX_MMC_BLOCK_DEVICE_H
> > +#define LINUX_MMC_BLOCK_DEVICE_H
> > +
> > +struct block_device;
> > +struct mmc_card;
> > +
> > +struct mmc_card *mmc_bdev_to_card(struct block_device *bdev);
> > +
> > +#endif /* LINUX_MMC_BLOCK_DEVICE_H */
> >
>
> Hello Ulf / Jens and everyone,
Hi Dmitry,
>
> Guys, what do you think about this change?
As I stated in an earlier reply, I am deferring the review from mmc
point of view, until I see some confirmation from Jens that he is okay
with adding a new partition format.
Otherwise I may just waste my time on reviews. I hope you understand.
Kind regards
Uffe
>
> Currently it's not allowed to compile MMC_BLOCK as a loadable kernel
> module if TEGRA_PARTITION is enabled because it depends on MMC_BLOCK
> presence. I'm curious if this situation could be improved by moving
> mmc_bdev_to_card() to linux/mmc/blkdev.h and then:
>
> 1. Moving all private mmc/core/block.c structs to the public
> linux/mmc/blkdev.h.
>
> 2. Or adding a "private opaque" pointer to a struct block_device and
> setting it to md->queue.card, for example.
>
> 3. I see that struct block_device already has some bd_private field, but
> I'm not sure whether it could be used for what I'm trying to achieve.
> Actually I don't see where bd_private is used in kernel at all.
>
> I'd like get yours feedback, thanks in advance.
next prev parent reply other threads:[~2020-05-18 7:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 2:12 [PATCH v6 0/7] Introduce NVIDIA Tegra Partition Table Dmitry Osipenko
2020-05-17 2:12 ` [PATCH v6 1/7] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko
2020-05-17 2:12 ` [PATCH v6 2/7] mmc: block: Add mmc_bdev_to_card() helper Dmitry Osipenko
2020-05-17 23:55 ` Dmitry Osipenko
2020-05-18 7:24 ` Ulf Hansson [this message]
2020-05-18 7:51 ` Dmitry Osipenko
2020-05-17 2:12 ` [PATCH v6 3/7] partitions: Introduce NVIDIA Tegra Partition Table Dmitry Osipenko
2020-05-17 2:12 ` [PATCH v6 4/7] partitions/efi: Support GPT entry lookup at a non-standard location Dmitry Osipenko
2020-05-17 2:12 ` [PATCH v6 5/7] partitions/efi: Improve coding style Dmitry Osipenko
2020-05-17 2:12 ` [PATCH v6 6/7] partitions/tegra: Support enforced GPT scanning Dmitry Osipenko
2020-05-17 2:12 ` [PATCH v6 7/7] soc/tegra: Expose Boot Configuration Table via sysfs Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFrGbKSx=afZCNBN_r_6iNm_TX0tZVRLK05ZUTDBGvAuyA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=axboe@kernel.dk \
--cc=blaws05@gmail.com \
--cc=danindrey@mail.ru \
--cc=dave@stgolabs.net \
--cc=david@ixit.cz \
--cc=digetx@gmail.com \
--cc=gilles@grandou.net \
--cc=hch@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nils@naltan.com \
--cc=pgwipeout@gmail.com \
--cc=rdunlap@infradead.org \
--cc=ryan@edited.us \
--cc=steve@einval.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).