linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miao Wang <shankerwangmiao@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: support bio merge for multi-range discard
Date: Tue, 22 Jun 2021 16:35:11 +0800	[thread overview]
Message-ID: <CB477D73-2867-4907-8CEC-6EE85A4AAC21@gmail.com> (raw)
In-Reply-To: <20210622065511.GB29691@lst.de>


> 2021年06月22日 14:55,Christoph Hellwig <hch@lst.de> 写道:
> 
> On Wed, Jun 09, 2021 at 08:45:56AM +0800, Ming Lei wrote:
>> diff --git a/block/blk-merge.c b/block/blk-merge.c
>> index bcdff1879c34..65210e9a8efa 100644
>> --- a/block/blk-merge.c
>> +++ b/block/blk-merge.c
>> @@ -724,10 +724,10 @@ static inline bool blk_discard_mergable(struct request *req)
>> static enum elv_merge blk_try_req_merge(struct request *req,
>> 					struct request *next)
>> {
>> -	if (blk_discard_mergable(req))
>> -		return ELEVATOR_DISCARD_MERGE;
>> -	else if (blk_rq_pos(req) + blk_rq_sectors(req) == blk_rq_pos(next))
>> +	if (blk_rq_pos(req) + blk_rq_sectors(req) == blk_rq_pos(next))
>> 		return ELEVATOR_BACK_MERGE;
> 
> Oh well, this breaks my previous suggestions.
> 
>> +		struct req_discard_range r;
>> +
>> +		rq_for_each_discard_range(r, req) {
> 
> ... and I can't say I like this rather complex iterator.
> 
> What is the problem of just fixing the raid code to not submit stupidly
> small discard requests instead?

Yes, raid code should indeed be fixed. However, the way discard
requests are getting merged is not correct. 

I understand your concern about complex iterator. I believe it is because
the difference between discard requests and normal read/write requests. 
Discard requests are without data and allowed to be non-contiguous, while
normal requests, which blk-merge was originally dealing with, are with 
data buffers and should be contiguous. Actually, correct me if wrong, the 
current request struct lacks the ability to express non-contiguous bio's.
Ming's patch, by introducing the rq_for_each_discard_range iterator, 
partially enables the request struct to express non-contiguous bio's.

Cheers, 

Miao Wang

  reply	other threads:[~2021-06-22  8:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  0:45 [PATCH 0/2] block: discard merge fix & improvement Ming Lei
2021-06-09  0:45 ` [PATCH 1/2] block: fix discard request merge Ming Lei
2021-06-22  6:53   ` Christoph Hellwig
2021-06-22  7:51     ` Ming Lei
2021-06-09  0:45 ` [PATCH 2/2] block: support bio merge for multi-range discard Ming Lei
2021-06-09  3:05   ` Wang Shanker
2021-06-09  6:12     ` Ming Lei
2021-06-09  6:57       ` Wang Shanker
2021-06-22  6:55   ` Christoph Hellwig
2021-06-22  8:35     ` Miao Wang [this message]
2021-06-14 22:00 ` [PATCH 0/2] block: discard merge fix & improvement Ming Lei
2021-06-22  3:53   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB477D73-2867-4907-8CEC-6EE85A4AAC21@gmail.com \
    --to=shankerwangmiao@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --subject='Re: [PATCH 2/2] block: support bio merge for multi-range discard' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).