linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>, Ming Lei <ming.lei@redhat.com>,
	Jens Axboe <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Christoph Hellwig <hch@lst.de>
Cc: Daniel Wagner <dwagner@suse.de>, Wen Xiong <wenxiong@us.ibm.com>,
	John Garry <john.garry@huawei.com>
Subject: Re: [PATCH 1/2] blk-mq: not deactivate hctx if the device doesn't use managed irq
Date: Wed, 30 Jun 2021 21:57:05 +0000	[thread overview]
Message-ID: <CH2PR04MB70781FC64AC0621F7E55B408E7019@CH2PR04MB7078.namprd04.prod.outlook.com> (raw)
In-Reply-To: 0f8be11b-c6de-1c2b-323b-1e059c2ac4f8@grimberg.me

On 2021/07/01 3:58, Sagi Grimberg wrote:
> 
>>> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
>>> index 21140132a30d..600c5dd1a069 100644
>>> --- a/include/linux/blk-mq.h
>>> +++ b/include/linux/blk-mq.h
>>> @@ -403,6 +403,7 @@ enum {
>>>   	 */
>>>   	BLK_MQ_F_STACKING	= 1 << 2,
>>>   	BLK_MQ_F_TAG_HCTX_SHARED = 1 << 3,
>>> +	BLK_MQ_F_NOT_USE_MANAGED_IRQ = 1 << 4,
>>
>> My 2 cents: BLK_MQ_F_NO_MANAGED_IRQ may be a better/shorter name.
> 
> Maybe BLK_MQ_F_UNMANAGED_IRQ?

Even better :)


-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2021-06-30 21:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  7:49 [PATCH 0/2] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-06-29  7:49 ` [PATCH 1/2] blk-mq: not deactivate hctx if the device doesn't use managed irq Ming Lei
2021-06-29 12:39   ` Hannes Reinecke
2021-06-29 14:17     ` Ming Lei
2021-06-29 15:49   ` John Garry
2021-06-30  0:32     ` Ming Lei
2021-06-30  9:25       ` John Garry
2021-07-01  9:52       ` Christoph Hellwig
2021-06-29 23:30   ` Damien Le Moal
2021-06-30 18:58     ` Sagi Grimberg
2021-06-30 21:57       ` Damien Le Moal [this message]
2021-07-01 14:20         ` Keith Busch
2021-06-29  7:49 ` [PATCH 2/2] nvme: pass BLK_MQ_F_NOT_USE_MANAGED_IRQ for fc/rdma/tcp/loop Ming Lei
2021-06-30  8:15   ` Hannes Reinecke
2021-06-30  8:47     ` Ming Lei
2021-06-30  8:18 ` [PATCH 0/2] blk-mq: fix blk_mq_alloc_request_hctx Hannes Reinecke
2021-06-30  8:42   ` Ming Lei
2021-06-30  9:43     ` Hannes Reinecke
2021-06-30  9:53       ` Ming Lei
2021-06-30 18:59         ` Sagi Grimberg
2021-06-30 19:46           ` Hannes Reinecke
2021-06-30 23:59             ` Ming Lei
2021-07-01  8:00               ` Hannes Reinecke
2021-07-01  9:13                 ` Ming Lei
2021-07-02  9:47             ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR04MB70781FC64AC0621F7E55B408E7019@CH2PR04MB7078.namprd04.prod.outlook.com \
    --to=damien.lemoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=hch@lst.de \
    --cc=john.garry@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).