From: Gulam Mohamed <gulam.mohamed@oracle.com>
To: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: RE: [PATCH 1/2] block: prevent block device lookups at the beginning of del_gendisk
Date: Thu, 20 May 2021 17:37:18 +0000 [thread overview]
Message-ID: <CO1PR10MB4563BDF0F824F9E16EFBA102982A9@CO1PR10MB4563.namprd10.prod.outlook.com> (raw)
In-Reply-To: <YJ9rkRGG5SUyjgsg@T590>
-----Original Message-----
From: Ming Lei <ming.lei@redhat.com>
Sent: Saturday, May 15, 2021 12:05 PM
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk; Gulam Mohamed <gulam.mohamed@oracle.com>; linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: prevent block device lookups at the beginning of del_gendisk
On Fri, May 14, 2021 at 03:18:41PM +0200, Christoph Hellwig wrote:
> As an artifact of how gendisk lookup used to work in earlier kernels,
> GENHD_FL_UP is only cleared very late in del_gendisk, and a global
> lock is used to prevent opens from succeeding while del_gendisk is
> tearing down the gendisk. Switch to clearing the flag early and under
> bd_mutex so that callers can use bd_mutex to stabilize the flag, which
> removes the need for the global mutex.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
I have tested these patches on latest kernel in our environment and didn't find any issue. The fix is working fine.
Tested-by: Gulam Mohamed <gulam.mohamed@oracle.com>
--
Ming
next prev parent reply other threads:[~2021-05-20 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 13:18 fix a race between del_gendisk and BLKRRPART v2 Christoph Hellwig
2021-05-14 13:18 ` [PATCH 1/2] block: prevent block device lookups at the beginning of del_gendisk Christoph Hellwig
2021-05-15 6:34 ` Ming Lei
2021-05-20 17:37 ` Gulam Mohamed [this message]
2021-05-14 13:18 ` [PATCH 2/2] block: fix a race between del_gendisk and BLKRRPART Christoph Hellwig
2021-05-15 6:35 ` Ming Lei
2021-05-20 17:37 ` Gulam Mohamed
2021-05-20 8:14 ` fix a race between del_gendisk and BLKRRPART v2 Christoph Hellwig
2021-05-20 13:59 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-05-12 16:50 fix a race between del_gendisk and BLKRRPART Christoph Hellwig
2021-05-12 16:50 ` [PATCH 1/2] block: prevent block device lookups at the beginning of del_gendisk Christoph Hellwig
2021-05-13 0:11 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR10MB4563BDF0F824F9E16EFBA102982A9@CO1PR10MB4563.namprd10.prod.outlook.com \
--to=gulam.mohamed@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).