From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH V3 1/3] block: add a zone condition debug helper
Date: Wed, 25 Mar 2020 05:20:02 +0000 [thread overview]
Message-ID: <CO2PR04MB234368CCA125D6DD0A1C376CE7CE0@CO2PR04MB2343.namprd04.prod.outlook.com> (raw)
In-Reply-To: BYAPR04MB49659AFBB6519B9E9ABC51E186CE0@BYAPR04MB4965.namprd04.prod.outlook.com
On 2020/03/25 13:31, Chaitanya Kulkarni wrote:
> On 03/24/2020 08:27 PM, Damien Le Moal wrote:
>>> {
>>>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>>>> index 53a1325efbc3..0070f26b9579 100644
>>>> --- a/include/linux/blkdev.h
>>>> +++ b/include/linux/blkdev.h
>>>> @@ -887,6 +887,9 @@ extern void blk_execute_rq_nowait(struct request_queue *, struct gendisk *,
>>>> /* Helper to convert REQ_OP_XXX to its string format XXX */
>>>> extern const char *blk_op_str(unsigned int op);
>>>>
>>>> +/* Helper to convert BLK_ZONE_ZONE_XXX to its string format XXX */
>>>> +extern const char *blk_zone_cond_str(enum blk_zone_cond zone_cond);
>>>> +
>> I do not think that the extern is needed here. And I think that this declaration
>> should go under #ifdef CONFIG_BLK_DEV_ZONED since its code is compiled only if
>> that config option is enabled.
>>
>
> Are you suggesting like following ?
>
> +#ifdef CONFIG_BLK_DEV_ZONED
> +/* Helper to convert BLK_ZONE_ZONE_XXX to its string format XXX */
> +const char *blk_zone_cond_str(enum blk_zone_cond zone_cond);
> +#endif /* CONFIG_BLK_DEV_ZONED */
Yes, That is what I meant. But may be do not add another #ifdef and simply move
the declaration within one of the existing #ifdef CONFIG_BLK_DEV_ZONED in
blkdev.h ? Less #ifdef is always better :)
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2020-03-25 5:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 2:16 [PATCH V3 0/3] null_blk: add tracepoints for zoned mode Chaitanya Kulkarni
2020-03-25 2:16 ` [PATCH V3 1/3] block: add a zone condition debug helper Chaitanya Kulkarni
2020-03-25 3:27 ` Damien Le Moal
2020-03-25 4:31 ` Chaitanya Kulkarni
2020-03-25 5:20 ` Damien Le Moal [this message]
2020-03-25 2:16 ` [PATCH V3 2/3] null_blk: add tracepoint helpers for zoned mode Chaitanya Kulkarni
2020-03-25 3:28 ` Damien Le Moal
2020-03-25 2:16 ` [PATCH V3 3/3] null_blk: add trace in null_blk_zoned.c Chaitanya Kulkarni
2020-03-27 3:12 ` [PATCH V3 0/3] null_blk: add tracepoints for zoned mode Chaitanya Kulkarni
2020-03-27 15:35 ` Jens Axboe
2020-03-27 16:05 ` Damien Le Moal
2020-03-27 16:25 ` Jens Axboe
2020-03-27 19:35 ` Chaitanya Kulkarni
2020-03-27 19:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO2PR04MB234368CCA125D6DD0A1C376CE7CE0@CO2PR04MB2343.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).