From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Omar Sandoval <osandov@fb.com>,
Masato Suzuki <masato.suzuki@wdc.com>,
Jens Axboe <axboe@kernel.dk>,
Matias Bjorling <Matias.Bjorling@wdc.com>,
Hannes Reinecke <hare@suse.de>, Mike Snitzer <snitzer@redhat.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH blktests v3 03/13] block/004: Adjust fio conditions for zoned block devices
Date: Mon, 28 Jan 2019 10:13:51 +0000 [thread overview]
Message-ID: <CY1PR04MB2268DDF26D6633533F7F34F4ED960@CY1PR04MB2268.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190125210901.GB26739@vader
On 1/26/19 6:09 AM, Omar Sandoval wrote:
> On Fri, Jan 18, 2019 at 06:44:43PM +0900, Shin'ichiro Kawasaki wrote:
>> @@ -16,10 +17,25 @@ requires() {
>> test_device() {
>> echo "Running ${TEST_NAME}"
>>
>> + local directio=""
>> + local zbdmode=""
>> +
>> + if _test_dev_is_zoned; then
>> + if ! _have_fio_zbd_zonemode; then
>> + echo "${SKIP_REASON}"
>> + return 1
>> + fi
>
> This will be marked as a failure instead of skipped. This check can be
> in device_requires instead:
>
> device_requires() {
> ! _test_dev_is_zoned || _have_fio_zbd_zonemode
> }
Thanks. Will change as suggested.
>> + _test_dev_queue_set scheduler deadline
>> +
>> + directio="--direct=1"
>> + zbdmode="--zonemode=zbd"
>> + fi
>> +
>> FIO_PERF_FIELDS=("write iops")
>> _fio_perf --bs=4k --rw=randwrite --norandommap --fsync=1 \
>> --number_ios=256 --numjobs=64 --name=flushes \
>> - --filename="$TEST_DEV"
>> + ${directio} ${zbdmode} --filename="$TEST_DEV"
>
> I'm surprised that shellcheck is smart enough to see that directio and
> zbdmode are always one word so this doesn't need quotes :)
Yes, and if I quote ${directio} and ${zbdmode}, fio fails with error message
"unable to open '' job file". I leave them without quotes.
--
Best Regards,
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2019-01-28 10:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 9:44 [PATCH blktests v3 00/13] Implement zoned block device support Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 01/13] config: Introduce RUN_ZONED_TESTS variable and CAN_BE_ZONED flag Shin'ichiro Kawasaki
2019-01-25 20:59 ` Omar Sandoval
2019-01-28 10:07 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 02/13] common: Introduce _have_fio_zbd_zonemode() helper function Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 03/13] block/004: Adjust fio conditions for zoned block devices Shin'ichiro Kawasaki
2019-01-25 21:09 ` Omar Sandoval
2019-01-28 10:13 ` Shinichiro Kawasaki [this message]
2019-01-18 9:44 ` [PATCH blktests v3 04/13] block: Whitelist tests supporting " Shin'ichiro Kawasaki
2019-01-25 21:11 ` Omar Sandoval
2019-01-28 10:37 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 05/13] check: Introduce fallback_device() and cleanup_fallback_device() Shin'ichiro Kawasaki
2019-01-25 21:14 ` Omar Sandoval
2019-01-28 10:54 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 06/13] common: Introduce _dd() helper function Shin'ichiro Kawasaki
2019-01-25 21:17 ` Omar Sandoval
2019-01-28 12:18 ` Shinichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 07/13] src: Introduce zbdioctl program Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 08/13] tests: Introduce zbd test group Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 09/13] zbd/001: sysfs and ioctl consistency test Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 10/13] zbd/002: report zone test Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 11/13] zbd/003: Test sequential zones reset Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 12/13] zbd/004: Check write split accross sequential zones Shin'ichiro Kawasaki
2019-01-18 9:44 ` [PATCH blktests v3 13/13] zbd/005: Test write ordering Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY1PR04MB2268DDF26D6633533F7F34F4ED960@CY1PR04MB2268.namprd04.prod.outlook.com \
--to=shinichiro.kawasaki@wdc.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masato.suzuki@wdc.com \
--cc=osandov@fb.com \
--cc=osandov@osandov.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).