From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Coly Li <colyli@suse.de>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>
Subject: Re: [RFC PATCH v4 1/3] bcache: export bcache zone information for zoned backing device
Date: Wed, 3 Jun 2020 00:58:49 +0000 [thread overview]
Message-ID: <CY4PR04MB3751543D5DA3C799B4C8A196E7880@CY4PR04MB3751.namprd04.prod.outlook.com> (raw)
In-Reply-To: c6492f79-423e-b37c-261c-80e4b26081ab@suse.de
On 2020/06/02 21:50, Coly Li wrote:
>>> /* convert back to LBA of the bcache device*/
>>> zone->start -= data_offset;
>>> if (zone->cond != BLK_ZONE_COND_NOT_WP)
>>> zone->wp -= data_offset;
>>
>> Since you have the BLK_ZONE_COND_NOT_WP condition in the switch-case,
>> this is not needed.
>>
>>>
>>> switch (zone->cond) {
>>> case BLK_ZONE_COND_NOT_WP:
>>> /* No write pointer available */
>>> break;
>>> case BLK_ZONE_COND_EMPTY:
>>
>> zone->wp = zone->start;
>>
>
> Correct me if I am wrong. I assume when the zone is in empty condition,
> LBA of zone->wp should be exactly equal to zone->start before bcache
> does the conversion. Therefore 'zone->wp - data_offset' should still be
> equal to 'zone->start - data_offset'. Therefore explicitly handle it in
> 'case BLK_ZONE_COND_EMPTY:' should be equal to handle it in 'default:' part.
Yes, for an empty zone, the zone wp is always equal to the start sector of the
zone. So yes, for an empty zone, wp - data_offset is correct. But it is not
necessary since you already need to do zone->start -= data_offset, all you need
to do for an empty zone is: zone->wp = zone->start. That is less arithmetic (no
need for the subtraction), so is faster :)
This code you have:
if (zone->cond != BLK_ZONE_COND_NOT_WP)
zone->wp -= data_offset;
will indeed lead to the correct result for an empty zone, but as I explained, it
will also do the subtraction for zone conditions with an undefined value. No
need to do all this. A switch case handling all conditions makes things very clear.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2020-06-03 0:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 12:18 [RFC PATCH v4 0/3] bcache: support zoned device as bcache backing device Coly Li
2020-05-22 12:18 ` [RFC PATCH v4 1/3] bcache: export bcache zone information for zoned " Coly Li
2020-05-25 1:10 ` Damien Le Moal
2020-06-01 12:34 ` Coly Li
2020-06-02 8:48 ` Damien Le Moal
2020-06-02 12:50 ` Coly Li
2020-06-03 0:58 ` Damien Le Moal [this message]
2020-05-22 12:18 ` [RFC PATCH v4 2/3] bcache: handle zone management bios for bcache device Coly Li
2020-05-25 1:24 ` Damien Le Moal
2020-06-01 16:06 ` Coly Li
2020-06-02 8:54 ` Damien Le Moal
2020-06-02 10:18 ` Coly Li
2020-06-03 0:51 ` Damien Le Moal
2020-05-22 12:18 ` [RFC PATCH v4 3/3] bcache: reject writeback cache mode for zoned backing device Coly Li
2020-05-25 1:26 ` Damien Le Moal
2020-06-01 16:09 ` Coly Li
2020-05-25 5:25 ` [RFC PATCH v4 0/3] bcache: support zoned device as bcache " Damien Le Moal
2020-05-25 8:14 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR04MB3751543D5DA3C799B4C8A196E7880@CY4PR04MB3751.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=colyli@suse.de \
--cc=hare@suse.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).