From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97A5C433E0 for ; Fri, 26 Jun 2020 06:38:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9CDB2076E for ; Fri, 26 Jun 2020 06:38:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="q7/1NKkk"; dkim=pass (1024-bit key) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="wGIAmrdY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727917AbgFZGir (ORCPT ); Fri, 26 Jun 2020 02:38:47 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:26557 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbgFZGiq (ORCPT ); Fri, 26 Jun 2020 02:38:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1593153525; x=1624689525; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=4wnY9jVExZlFGMGWJeRJXFas18H+o0EG3vUtAtDxiYE=; b=q7/1NKkksEI80SBts7HtjTFXr7G/RKEPT4Pew2ZXCOXtsT4/tstw2SID L+iuDfni569BOsjYLEJH0STfzRcIfIQgDfVV65u81Hp6xLNUZs72+ZwO/ N7XYZA4QndKhg+0098WR9YFIXmvHXHLld6Ce9KLSX3mTTu344ClkhEh5c MKSX58mRdi8mGYVZtb0+TFBGDwdgD7zDqqYsJGSLIAFubUjB46Pn6J4Ef KQIJ+qNFpTNkPCrEg9Ocs/bLbM725/VoAlNyQ+ff5xC9Od+/t8gK6wwJI 0b2emaKByfcXrrBwzFEGwT6BZjn6Ct+8b+3gfa+uhQg9qB8CT2RVBvf0A g==; IronPort-SDR: 73wv1I9xZV1jePHIUsWLu3eYRalc6wmfR4iQ1V635DJhcqiZ59VIgfotgMTQNkGDzRvE3Vp3CO CXXehLKrPDhCYvY83aYIkBibcWWk5HEKGN9P1LZVncwMa2eujIeCNA85iT09pQL50/2yQUWGrN 4RaLbSbAebPriFyeQ9VttVWX1xtyCpoCev9oQosZzTJ0vfgXQ5faJ3Eqiusxi6rp5pyqQlD91V LjHjb3fzfjQIGleLgA2BvNVlKxLn5bNf5BDW2QgdhoMKkgNPEmvvWNkwECJdIwDqrkFzpYJYn/ OJw= X-IronPort-AV: E=Sophos;i="5.75,282,1589212800"; d="scan'208";a="250203577" Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hgst.iphmx.com with ESMTP; 26 Jun 2020 14:38:44 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iN+uokCjbSVoLGq/044JLbf+SX8xpFzhR/9vlhAhMIc0klRsb6bdBWTEFidQ+FqmhVfJwwgNNnZoNmrooOpW7KTmLv4jrZ48IXF4xn83cgJ1Bycxzw75kfmEb4YQQ08x0+CULJ27buJriuG0hTwkhkEqod3Fm5EE4q52jMHGO//jSfA1TPIMoJuz7BVwgWvpjYd9pyMlLRDDRkrt+tTgMlVXDYnTeHN7aJ7HR0OeJrRTkt87xt0k92jwNN0N7AQCQkKZdaslQ5Dz+MB/BdUsDj2cZc2ReGyF/EARm7Jlm08uf5gRb2ASHAd2IiO1AfzyVJZQ92GdeAAx3CeTSZY+/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4DaxkXyICe7US2JM85ST3Hsi3Sv8a42hLlx7VW2c8Zk=; b=bgJhhDOIl8L9SnksSphCyaXCMAPIk4vM6FZDIk7EBhbfu74e1zO0ai9rNsuA6Z35re1f8GcpElcd+H/BHNGXOi2dF9PqhaV2SVAxsIjwLHMNhnOtiEygIOJApL4cpO6XfRW9Orl3xLZvo+xwdgy7UjV06SCM3yCce3GJojOmELFC1n++grb/NVu95/EFqnDpH7A4qV3wYJ+U4wKHEKTxN2dGt6J2sFW7XGGEk7UoIgepfRXkm0cIQ/RA7HjSrbxviRu/6QBEZwkon2qo78OmadlP3q8LKLo6xOUYXLwooo+BqYbuL1EsF8dVYD2dwmmZOxBzmFuDzuWCZaQ+baMyWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4DaxkXyICe7US2JM85ST3Hsi3Sv8a42hLlx7VW2c8Zk=; b=wGIAmrdY97HJc9oNRuYweuH48mfF3D79MtfJfdiC8+glL6LFgS1aJJAZiYjWH8Ve8ljCsvS1AUa/8Hfay0Snqzq+MkL4vy0MwKyyEwmSrr6PyXW+TPw4gAGgrci4Cjz0teQGEDRK6abOeH/bfNfnOZtDFAldrm2AVLk6x0M44Ow= Received: from CY4PR04MB3751.namprd04.prod.outlook.com (2603:10b6:903:ec::14) by CY4PR0401MB3586.namprd04.prod.outlook.com (2603:10b6:910:8e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.23; Fri, 26 Jun 2020 06:38:43 +0000 Received: from CY4PR04MB3751.namprd04.prod.outlook.com ([fe80::c593:f271:eebe:ac7]) by CY4PR04MB3751.namprd04.prod.outlook.com ([fe80::c593:f271:eebe:ac7%9]) with mapi id 15.20.3131.024; Fri, 26 Jun 2020 06:38:43 +0000 From: Damien Le Moal To: =?iso-8859-1?Q?Javier_Gonz=E1lez?= CC: "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "hch@lst.de" , "kbusch@kernel.org" , "sagi@grimberg.me" , "axboe@kernel.dk" , SelvaKumar S , Kanchan Joshi , Nitesh Shetty Subject: Re: [PATCH 5/6] block: add zone attr. to zone mgmt IOCTL struct Thread-Topic: [PATCH 5/6] block: add zone attr. to zone mgmt IOCTL struct Thread-Index: AQHWSutSdYSwrXPXKEe2iCYs45u1PA== Date: Fri, 26 Jun 2020 06:38:43 +0000 Message-ID: References: <20200625122152.17359-1-javier@javigon.com> <20200625122152.17359-6-javier@javigon.com> <20200626060332.erje6ohzmhxzfaj4@mpHalley.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: javigon.com; dkim=none (message not signed) header.d=none;javigon.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [129.253.182.57] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a38b2858-71ee-4679-040d-08d8199b91ef x-ms-traffictypediagnostic: CY4PR0401MB3586: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0446F0FCE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 52A9MicQj/6uUK05ctGoTOEyjjxPVQHzlep/rM73guEXGew+uLQVFTCDmBC5YvitDcjAllTWklH0JF1t+6lufOQEGf2Zq5rPXjwhz+C/Vu9tiDmNLPJiCy19jzx8S5d/zCm5jDB3R9u1i4+S9jnS6OBOb4oWLKE9nYadQeMaT5xG41BVF6FSVZLgc6XZW/SOSNcj9gV+uRSSOI7PGD7reiS+0TOGA1bSXo/RrYis9UyLsbbyIoz6wrrpX/sA6Kv9NTkDgJJNuZDdt7VbOGp7MjzKAa8wx2hCKGhyhXneyiWv9sAt90Yc3tTnwgTQWROKHYttOMpPuwRT2eGZ1IzGVg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR04MB3751.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(86362001)(5660300002)(8936002)(6916009)(52536014)(8676002)(66446008)(66476007)(33656002)(64756008)(66556008)(66946007)(76116006)(71200400001)(83380400001)(91956017)(4326008)(26005)(186003)(53546011)(55016002)(9686003)(2906002)(6506007)(7416002)(66574015)(316002)(478600001)(54906003)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: cziS756kiEy+BS7my8pHfoC2bsUoP11aPJZxSgZBJxu5xyUXxVS80wk39F7839ZdTjH1+A8ubKEGTnk5P7XX1H63j1B2LYytiU+CnJ5Ud0Jf4mk1F5HDWaeyP0+8SIS564SLRJSg9PKWDi7SFvWq9t8dD2YHS6wzwDW9B40eUzjOGpcnMyyYhK/me6e10D3Bs+01dNaFsLML0PufLlgxTOruIJNMp3p/pzDNfc5ub3pqnrxocutFjW4l4L6T/o9H1mpTcLebVybF2bebhPWNf6Dil4nJHm+YAf7h4bhEtBM8mvNw3PzlQIBkmPfHMtKHnVnCcQZg59YolJX8lPHBYZjzPQh4lj2wHi3laoT174oNEY9RQPUeo4elkF1T3mWQdpT2sB2UHgga6fGsnw3L//eOB4ckIkL3y5sex/8lalhqer+v2vSzYI+fEbgPghFAY2KHBht1W7FbRNQp+22lPbroGPb1aHrmpMwL+i+x7En/7CAMFglSIsYTiq25Tlqs x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: a38b2858-71ee-4679-040d-08d8199b91ef X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2020 06:38:43.0731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pHVxecphG+oWbf3pzMQhmljeort51hdxqF5RsEwYO0ZhzlluxtoXhn3Ii5l0Y+HWzolY4bUFIoglSLMFyNH2Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0401MB3586 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2020/06/26 15:03, Javier Gonz=E1lez wrote:=0A= > On 26.06.2020 01:45, Damien Le Moal wrote:=0A= >> On 2020/06/25 21:22, Javier Gonz=E1lez wrote:=0A= >>> From: Javier Gonz=E1lez =0A= >>>=0A= >>> Add zone attributes field to the blk_zone structure. Use ZNS attributes= =0A= >>> as base for zoned block devices in general.=0A= >>>=0A= >>> Signed-off-by: Javier Gonz=E1lez =0A= >>> Signed-off-by: SelvaKumar S =0A= >>> Signed-off-by: Kanchan Joshi =0A= >>> Signed-off-by: Nitesh Shetty =0A= >>> ---=0A= >>> drivers/nvme/host/zns.c | 1 +=0A= >>> include/uapi/linux/blkzoned.h | 13 ++++++++++++-=0A= >>> 2 files changed, 13 insertions(+), 1 deletion(-)=0A= >>>=0A= >>> diff --git a/drivers/nvme/host/zns.c b/drivers/nvme/host/zns.c=0A= >>> index 258d03610cc0..7d8381fe7665 100644=0A= >>> --- a/drivers/nvme/host/zns.c=0A= >>> +++ b/drivers/nvme/host/zns.c=0A= >>> @@ -195,6 +195,7 @@ static int nvme_zone_parse_entry(struct nvme_ns *ns= ,=0A= >>> zone.capacity =3D nvme_lba_to_sect(ns, le64_to_cpu(entry->zcap));=0A= >>> zone.start =3D nvme_lba_to_sect(ns, le64_to_cpu(entry->zslba));=0A= >>> zone.wp =3D nvme_lba_to_sect(ns, le64_to_cpu(entry->wp));=0A= >>> + zone.attr =3D entry->za;=0A= >>>=0A= >>> return cb(&zone, idx, data);=0A= >>> }=0A= >>> diff --git a/include/uapi/linux/blkzoned.h b/include/uapi/linux/blkzone= d.h=0A= >>> index 0c49a4b2ce5d..2e43a00e3425 100644=0A= >>> --- a/include/uapi/linux/blkzoned.h=0A= >>> +++ b/include/uapi/linux/blkzoned.h=0A= >>> @@ -82,6 +82,16 @@ enum blk_zone_report_flags {=0A= >>> BLK_ZONE_REP_CAPACITY =3D (1 << 0),=0A= >>> };=0A= >>>=0A= >>> +/**=0A= >>> + * Zone Attributes=0A= >>=0A= >> This is a user interface file. Please document the meaning of each attri= bute.=0A= >>=0A= > =0A= > Sure.=0A= > =0A= >>> + */=0A= >>> +enum blk_zone_attr {=0A= >>> + BLK_ZONE_ATTR_ZFC =3D 1 << 0,=0A= >>> + BLK_ZONE_ATTR_FZR =3D 1 << 1,=0A= >>> + BLK_ZONE_ATTR_RZR =3D 1 << 2,=0A= >>> + BLK_ZONE_ATTR_ZDEV =3D 1 << 7,=0A= >> These are ZNS specific, right ? Integrating the 2 ZBC/ZAC attributes in = this=0A= >> list would be nice, namely non_seq and reset. That will imply patching s= d.c.=0A= >>=0A= > =0A= > Of course. I will look at non_seq and reset. Any other that should go=0A= > in here?=0A= =0A= See ZBC specs. These are the only 2 zone attributes defined.=0A= =0A= > =0A= >>> +};=0A= >>> +=0A= >>> /**=0A= >>> * struct blk_zone - Zone descriptor for BLKREPORTZONE ioctl.=0A= >>> *=0A= >>> @@ -108,7 +118,8 @@ struct blk_zone {=0A= >>> __u8 cond; /* Zone condition */=0A= >>> __u8 non_seq; /* Non-sequential write resources active */=0A= >>> __u8 reset; /* Reset write pointer recommended */=0A= >>> - __u8 resv[4];=0A= >>> + __u8 attr; /* Zone attributes */=0A= >>> + __u8 resv[3];=0A= >>> __u64 capacity; /* Zone capacity in number of sectors */=0A= >>> __u8 reserved[24];=0A= >>> };=0A= >>>=0A= >>=0A= >> You are missing a BLK_ZONE_REP_ATTR report flag to indicate to the user = that the=0A= >> attr field is present, used and valid.=0A= >>=0A= >> enum blk_zone_report_flags {=0A= >> BLK_ZONE_REP_CAPACITY =3D (1 << 0),=0A= >> + BLK_ZONE_REP_ATTR =3D (1 << 1),=0A= >> };=0A= >>=0A= >> is I think needed.=0A= > =0A= > Good point. I will add that on a V2.=0A= > =0A= > Javier=0A= > =0A= =0A= =0A= -- =0A= Damien Le Moal=0A= Western Digital Research=0A=