Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Alexey Dobriyan <adobriyan@gmail.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] null_blk: fix spurious IO errors after failed past-wp access
Date: Sat, 15 Feb 2020 03:20:32 +0000
Message-ID: <DM6PR04MB5754FA61DFF5CA3C6912775886140@DM6PR04MB5754.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20200212202320.GA2704@avx2>

Alexey, thanks for the patch however the description is
not simple to understand.

I just sent a patch with a description and the test result.

On 02/12/2020 12:23 PM, Alexey Dobriyan wrote:
> Steps to reproduce:
>
> 	BLKRESETZONE zone 0
>
> 	// force EIO
> 	pwrite(fd, buf, 4096, 4096);
>
> 	[issue more IO including zone ioctls]
>
> It will start failing randomly including IO to unrelated zones because of
> ->error "reuse". Trigger can be partition detection as well if test is not
> run immediately which is even more entertaining.
>
> The fix is of course to clear ->error where necessary.
>
> Signed-off-by: Alexey Dobriyan (SK hynix)<adobriyan@gmail.com>
> ---
>
>   drivers/block/null_blk_main.c |    2 ++


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 20:23 Alexey Dobriyan
2020-02-15  3:20 ` Chaitanya Kulkarni [this message]
2020-02-19 16:35 ` Christoph Hellwig

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB5754FA61DFF5CA3C6912775886140@DM6PR04MB5754.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=adobriyan@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git