From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Paolo Valente <paolo.valente@linaro.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [PATCH v4 3/6] block: change ioprio_valid() to an inline function
Date: Wed, 11 Aug 2021 08:51:30 +0000 [thread overview]
Message-ID: <DM6PR04MB708110464CF08693EE8BFEABE7F89@DM6PR04MB7081.namprd04.prod.outlook.com> (raw)
In-Reply-To: PH0PR04MB7416DCAE9D84B4ED25E4C2ED9BF89@PH0PR04MB7416.namprd04.prod.outlook.com
On 2021/08/11 16:56, Johannes Thumshirn wrote:
> On 11/08/2021 05:37, Damien Le Moal wrote:
>> Change the ioprio_valid() macro in include/usapi/linux/ioprio.h to an uapi ~^
>
>> inline function declared on the kernel side in include/linux/ioprio.h.
>> Also improve checks on the class value by checking the upper bound
>> value.
>
> But I think it needs to stay in include/uapi/linux/ioprio.h as it's there
> since the 2.6.x days (I've checked back to v2.6.39.4) so the chance of
> user-space using it is quite high.
include/uapi/linux/ioprio.h is being introduced with kernel 5.15. This user
header did not exist now and in previous kernels. include/linux/ioprio.h has
been around for a while though, but that is a kernel header, not an application
header.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-08-11 8:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 3:36 [PATCH v4 0/6] IO priority fixes and improvements Damien Le Moal
2021-08-11 3:36 ` [PATCH v4 1/6] block: bfq: fix bfq_set_next_ioprio_data() Damien Le Moal
2021-08-11 3:36 ` [PATCH v4 2/6] block: improve ioprio class description comment Damien Le Moal
2021-08-11 3:36 ` [PATCH v4 3/6] block: change ioprio_valid() to an inline function Damien Le Moal
2021-08-11 7:56 ` Johannes Thumshirn
2021-08-11 8:51 ` Damien Le Moal [this message]
2021-08-11 9:14 ` Johannes Thumshirn
2021-08-11 3:37 ` [PATCH v4 4/6] block: fix IOPRIO_PRIO_CLASS() and IOPRIO_PRIO_VALUE() macros Damien Le Moal
2021-08-11 3:37 ` [PATCH v4 5/6] block: Introduce IOPRIO_NR_LEVELS Damien Le Moal
2021-08-11 3:37 ` [PATCH v4 6/6] block: fix default IO priority handling Damien Le Moal
2021-08-18 9:53 ` [PATCH v4 0/6] IO priority fixes and improvements Damien Le Moal
2021-08-18 13:24 ` Jens Axboe
2021-08-18 21:52 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB708110464CF08693EE8BFEABE7F89@DM6PR04MB7081.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=paolo.valente@linaro.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).