* [PATCH] xen-blkback: Remove needless request_queue NULL pointer check
@ 2021-09-10 2:24 Xu Wang
2021-09-10 2:37 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2021-09-10 2:24 UTC (permalink / raw)
To: konrad.wilk, roger.pau, axboe, xen-devel; +Cc: linux-block, linux-kernel
The request_queue pointer returned from bdev_get_queue() shall
never be NULL, so the null check is unnecessary, just remove it.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/block/xen-blkback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 33eba3df4dd9..f05132b9ddbf 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -516,7 +516,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
vbd->type |= VDISK_REMOVABLE;
q = bdev_get_queue(bdev);
- if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+ if test_bit(QUEUE_FLAG_WC, &q->queue_flags)
vbd->flush_support = true;
if (q && blk_queue_secure_erase(q))
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen-blkback: Remove needless request_queue NULL pointer check
2021-09-10 2:24 [PATCH] xen-blkback: Remove needless request_queue NULL pointer check Xu Wang
@ 2021-09-10 2:37 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2021-09-10 2:37 UTC (permalink / raw)
To: Xu Wang, konrad.wilk, roger.pau, axboe, xen-devel
Cc: linux-block, linux-kernel
On 2021/09/10 11:32, Xu Wang wrote:
> The request_queue pointer returned from bdev_get_queue() shall
> never be NULL, so the null check is unnecessary, just remove it.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/block/xen-blkback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index 33eba3df4dd9..f05132b9ddbf 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -516,7 +516,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
> vbd->type |= VDISK_REMOVABLE;
>
> q = bdev_get_queue(bdev);
> - if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
> + if test_bit(QUEUE_FLAG_WC, &q->queue_flags)
Missing parenthesis. Did you even compile this ?
> vbd->flush_support = true;
>
> if (q && blk_queue_secure_erase(q))
And why not change this one too ?
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-10 2:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 2:24 [PATCH] xen-blkback: Remove needless request_queue NULL pointer check Xu Wang
2021-09-10 2:37 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).