From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH] block: Remove an obsolete comment from sg_io()
Date: Tue, 13 Apr 2021 17:20:41 +0000 [thread overview]
Message-ID: <F9FE74B7-5367-49EA-AC27-27A146FFFD26@oracle.com> (raw)
In-Reply-To: <20210413034142.23460-1-bvanassche@acm.org>
> On Apr 12, 2021, at 10:41 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> Commit b7819b925918 ("block: remove the blk_execute_rq return value")
> changed the return type of blk_execute_rq() from int into void. That
> change made a comment in sg_io() obsolete. Hence remove that comment.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> block/scsi_ioctl.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> index 1048b0925567..1b3fe99b83a6 100644
> --- a/block/scsi_ioctl.c
> +++ b/block/scsi_ioctl.c
> @@ -353,10 +353,6 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk,
>
> start_time = jiffies;
>
> - /* ignore return value. All information is passed back to caller
> - * (if he doesn't check that is his problem).
> - * N.B. a non-zero SCSI status is _not_ necessarily an error.
> - */
> blk_execute_rq(bd_disk, rq, at_head);
>
> hdr->duration = jiffies_to_msecs(jiffies - start_time);
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-04-13 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 3:41 [PATCH] block: Remove an obsolete comment from sg_io() Bart Van Assche
2021-04-13 4:23 ` Chaitanya Kulkarni
2021-04-13 17:20 ` Himanshu Madhani [this message]
2021-04-13 17:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9FE74B7-5367-49EA-AC27-27A146FFFD26@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).