From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 01/17] mm: don't include <linux/blk-cgroup.h> in <linux/writeback.h>
Date: Wed, 15 Sep 2021 08:51:12 +0000 [thread overview]
Message-ID: <PH0PR04MB7416076F1368EC2978DF239C9BDB9@PH0PR04MB7416.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210915084918.GA25090@lst.de
On 15/09/2021 10:49, Christoph Hellwig wrote:
>
> .. but they aren't. All these headers indirectl pulled these headers
> in before and now don't.
>
> random32.c pulls in writeback.h through trace/events/random.h, which
> pulls in blk-cgroup.h, which pull in blkdev.h, which pulls in slab.h
> through some other weird twist of fate.
>
> The drm code also somehow manages to pull in writeback.h
>
Sh*t didn't notice that. But this doesn't sound healthy.
next prev parent reply other threads:[~2021-09-15 8:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 6:40 untangle the block headers Christoph Hellwig
2021-09-15 6:40 ` [PATCH 01/17] mm: don't include <linux/blk-cgroup.h> in <linux/writeback.h> Christoph Hellwig
2021-09-15 8:45 ` Johannes Thumshirn
2021-09-15 8:49 ` Christoph Hellwig
2021-09-15 8:51 ` Johannes Thumshirn [this message]
2021-09-15 6:40 ` [PATCH 02/17] mm: don't include <linux/blk-cgroup.h> in <linux/backing-dev.h> Christoph Hellwig
2021-09-15 9:11 ` Johannes Thumshirn
2021-09-15 6:40 ` [PATCH 03/17] mm: don't include <linux/blkdev.h> " Christoph Hellwig
2021-09-15 6:40 ` [PATCH 04/17] mm: remove spurious blkdev.h includes Christoph Hellwig
2021-09-15 8:51 ` Johannes Thumshirn
2021-09-15 6:40 ` [PATCH 05/17] arch: " Christoph Hellwig
2021-09-15 6:40 ` [PATCH 06/17] kernel: " Christoph Hellwig
2021-09-15 6:40 ` [PATCH 07/17] sched: move the <linux/blkdev.h> include out of kernel/sched/sched.h Christoph Hellwig
2021-09-15 6:40 ` [PATCH 08/17] block: remove the unused rq_end_sector macro Christoph Hellwig
2021-09-15 6:40 ` [PATCH 09/17] block: remove the unused blk_queue_state enum Christoph Hellwig
2021-09-15 6:40 ` [PATCH 10/17] block: remove the cmd_size field from struct request_queue Christoph Hellwig
2021-09-15 6:40 ` [PATCH 11/17] block: remove the struct blk_queue_ctx forward declaration Christoph Hellwig
2021-09-15 6:40 ` [PATCH 12/17] block: move elevator.h to block/ Christoph Hellwig
2021-09-15 6:40 ` [PATCH 13/17] block: drop unused includes in <linux/blkdev.h> Christoph Hellwig
2021-09-15 6:40 ` [PATCH 14/17] block: drop unused includes in <linux/genhd.h> Christoph Hellwig
2021-09-15 6:40 ` [PATCH 15/17] block: move a few merge helpers out of <linux/blkdev.h> Christoph Hellwig
2021-09-15 9:15 ` Johannes Thumshirn
2021-09-15 6:40 ` [PATCH 16/17] block: move integrity handling " Christoph Hellwig
2021-09-15 6:40 ` [PATCH 17/17] block: move struct request to blk-mq.h Christoph Hellwig
2021-09-15 9:19 ` Johannes Thumshirn
2021-09-20 12:33 untangle the block headers v2 Christoph Hellwig
2021-09-20 12:33 ` [PATCH 01/17] mm: don't include <linux/blk-cgroup.h> in <linux/writeback.h> Christoph Hellwig
2021-09-20 12:53 ` Johannes Thumshirn
2021-09-20 22:13 ` Bart Van Assche
2021-09-21 6:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR04MB7416076F1368EC2978DF239C9BDB9@PH0PR04MB7416.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).