* [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared
@ 2021-03-11 8:17 Nikolay Borisov
2021-03-11 8:25 ` Johannes Thumshirn
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Nikolay Borisov @ 2021-03-11 8:17 UTC (permalink / raw)
To: linux-block; +Cc: axboe, Nikolay Borisov
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
block/blk-mq-tag.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 9c92053e704d..99bc5fe14e9b 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
tags->nr_tags = total_tags;
tags->nr_reserved_tags = reserved_tags;
- if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
+ if (blk_mq_is_sbitmap_shared(flags))
return tags;
if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
@@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
{
- if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
+ if (!blk_mq_is_sbitmap_shared(flags)) {
sbitmap_queue_free(tags->bitmap_tags);
sbitmap_queue_free(tags->breserved_tags);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared
2021-03-11 8:17 [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared Nikolay Borisov
@ 2021-03-11 8:25 ` Johannes Thumshirn
2021-04-06 7:07 ` Nikolay Borisov
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2021-03-11 8:25 UTC (permalink / raw)
To: Nikolay Borisov, linux-block; +Cc: axboe
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared
2021-03-11 8:17 [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared Nikolay Borisov
2021-03-11 8:25 ` Johannes Thumshirn
@ 2021-04-06 7:07 ` Nikolay Borisov
2021-04-06 7:20 ` Hannes Reinecke
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Nikolay Borisov @ 2021-04-06 7:07 UTC (permalink / raw)
To: linux-block; +Cc: axboe
On 11.03.21 г. 10:17, Nikolay Borisov wrote:
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Ping
> ---
> block/blk-mq-tag.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 9c92053e704d..99bc5fe14e9b 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
> tags->nr_tags = total_tags;
> tags->nr_reserved_tags = reserved_tags;
>
> - if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
> + if (blk_mq_is_sbitmap_shared(flags))
> return tags;
>
> if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
> @@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
>
> void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
> {
> - if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
> + if (!blk_mq_is_sbitmap_shared(flags)) {
> sbitmap_queue_free(tags->bitmap_tags);
> sbitmap_queue_free(tags->breserved_tags);
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared
2021-03-11 8:17 [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared Nikolay Borisov
2021-03-11 8:25 ` Johannes Thumshirn
2021-04-06 7:07 ` Nikolay Borisov
@ 2021-04-06 7:20 ` Hannes Reinecke
2021-04-06 14:36 ` Himanshu Madhani
2021-04-06 15:24 ` Jens Axboe
4 siblings, 0 replies; 6+ messages in thread
From: Hannes Reinecke @ 2021-04-06 7:20 UTC (permalink / raw)
To: Nikolay Borisov, linux-block; +Cc: axboe
On 3/11/21 9:17 AM, Nikolay Borisov wrote:
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> block/blk-mq-tag.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 9c92053e704d..99bc5fe14e9b 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
> tags->nr_tags = total_tags;
> tags->nr_reserved_tags = reserved_tags;
>
> - if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
> + if (blk_mq_is_sbitmap_shared(flags))
> return tags;
>
> if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
> @@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
>
> void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
> {
> - if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
> + if (!blk_mq_is_sbitmap_shared(flags)) {
> sbitmap_queue_free(tags->bitmap_tags);
> sbitmap_queue_free(tags->breserved_tags);
> }
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared
2021-03-11 8:17 [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared Nikolay Borisov
` (2 preceding siblings ...)
2021-04-06 7:20 ` Hannes Reinecke
@ 2021-04-06 14:36 ` Himanshu Madhani
2021-04-06 15:24 ` Jens Axboe
4 siblings, 0 replies; 6+ messages in thread
From: Himanshu Madhani @ 2021-04-06 14:36 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: linux-block, axboe
> On Mar 11, 2021, at 2:17 AM, Nikolay Borisov <nborisov@suse.com> wrote:
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> block/blk-mq-tag.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 9c92053e704d..99bc5fe14e9b 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -517,7 +517,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
> tags->nr_tags = total_tags;
> tags->nr_reserved_tags = reserved_tags;
>
> - if (flags & BLK_MQ_F_TAG_HCTX_SHARED)
> + if (blk_mq_is_sbitmap_shared(flags))
> return tags;
>
> if (blk_mq_init_bitmap_tags(tags, node, alloc_policy) < 0) {
> @@ -529,7 +529,7 @@ struct blk_mq_tags *blk_mq_init_tags(unsigned int total_tags,
>
> void blk_mq_free_tags(struct blk_mq_tags *tags, unsigned int flags)
> {
> - if (!(flags & BLK_MQ_F_TAG_HCTX_SHARED)) {
> + if (!blk_mq_is_sbitmap_shared(flags)) {
> sbitmap_queue_free(tags->bitmap_tags);
> sbitmap_queue_free(tags->breserved_tags);
> }
> --
> 2.25.1
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared
2021-03-11 8:17 [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared Nikolay Borisov
` (3 preceding siblings ...)
2021-04-06 14:36 ` Himanshu Madhani
@ 2021-04-06 15:24 ` Jens Axboe
4 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2021-04-06 15:24 UTC (permalink / raw)
To: Nikolay Borisov, linux-block
On 3/11/21 1:17 AM, Nikolay Borisov wrote:
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-06 15:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 8:17 [PATCH] blk-mq: Always use blk_mq_is_sbitmap_shared Nikolay Borisov
2021-03-11 8:25 ` Johannes Thumshirn
2021-04-06 7:07 ` Nikolay Borisov
2021-04-06 7:20 ` Hannes Reinecke
2021-04-06 14:36 ` Himanshu Madhani
2021-04-06 15:24 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).