From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Christoph Hellwig <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] floppy: use block_size
Date: Fri, 26 Jun 2020 15:48:53 +0000 [thread overview]
Message-ID: <SN4PR0401MB35982FE9416D43ABF2CDBBC79B930@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200626080158.1998621-2-hch@lst.de
On 26/06/2020 10:03, Christoph Hellwig wrote:
> - size = bdev->bd_block_size;
> - if (!size)
> - size = 1024;
> -
Why is this correct? block_size() only returns 'bdev->bd_block_size' but I cannot
see where it's made sure bd_block_size is not 0. At least no calls to set_blocksize()
next prev parent reply other threads:[~2020-06-26 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 8:01 remove not needed fields from struct block_device Christoph Hellwig
2020-06-26 8:01 ` [PATCH 1/7] floppy: use block_size Christoph Hellwig
2020-06-26 15:48 ` Johannes Thumshirn [this message]
2020-06-26 15:50 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 2/7] dcssblk: don't set bd_block_size in ->open Christoph Hellwig
2020-06-26 15:54 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 3/7] block: simplify set_init_blocksize Christoph Hellwig
2020-06-26 8:01 ` [PATCH 4/7] block: remove the bd_block_size field from struct block_device Christoph Hellwig
2020-07-01 7:29 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 5/7] block: remove the bd_queue " Christoph Hellwig
2020-07-01 7:30 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 6/7] block: remove the unused bd_private " Christoph Hellwig
2020-07-01 7:31 ` Johannes Thumshirn
2020-06-26 8:01 ` [PATCH 7/7] block: remove the all_bdevs list Christoph Hellwig
2020-07-01 7:33 ` Johannes Thumshirn
2020-07-01 7:11 ` remove not needed fields from struct block_device Christoph Hellwig
2020-07-01 15:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB35982FE9416D43ABF2CDBBC79B930@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).