Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Hongnan Li <hongnan.li@linux.alibaba.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH] blk-iolatency:postpone ktime_get() execution until blk_iolatency_enabled() return true
Date: Wed, 1 Jul 2020 07:52:51 +0000
Message-ID: <SN4PR0401MB359850E5F42414D9ACBDE2059B6C0@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1593583467-18945-1-git-send-email-hongnan.li@linux.alibaba.com>

On 01/07/2020 08:05, Hongnan Li wrote:
> ktime_to_ns(ktime_get()) which is expensive do not need to be executed if
> blk_iolatency_enabled() return false in blkcg_iolatency_done_bio().
> Postponing ktime_to_ns(ktime_get()) execution can reduce CPU usage
> when blk_iolatency was disabled.
> 
> Signed-off-by: Hongnan Li <hongnan.li@linux.alibaba.com>
> ---
>  block/blk-iolatency.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
> index c128d50..8c1487e 100644
> --- a/block/blk-iolatency.c
> +++ b/block/blk-iolatency.c
> @@ -591,7 +591,7 @@ static void blkcg_iolatency_done_bio(struct rq_qos *rqos, struct bio *bio)
>  	struct rq_wait *rqw;
>  	struct iolatency_grp *iolat;
>  	u64 window_start;
> -	u64 now = ktime_to_ns(ktime_get());
> +
>  	bool issue_as_root = bio_issue_as_root_blkg(bio);
>  	bool enabled = false;
>  	int inflight = 0;
> @@ -608,6 +608,7 @@ static void blkcg_iolatency_done_bio(struct rq_qos *rqos, struct bio *bio)
>  	if (!enabled)
>  		return;
>  
> +	u64 now = ktime_to_ns(ktime_get());
>  	while (blkg && blkg->parent) {
>  		iolat = blkg_to_lat(blkg);
>  		if (!iolat) {
> 

You're mixing declarations and code.

please do
-	u64 now = ktime_to_ns(ktime_get());
+	u64 now;

[...]
+	now = ktime_to_ns(ktime_get());

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  6:04 Hongnan Li
2020-07-01  7:52 ` Johannes Thumshirn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN4PR0401MB359850E5F42414D9ACBDE2059B6C0@SN4PR0401MB3598.namprd04.prod.outlook.com \
    --to=johannes.thumshirn@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hongnan.li@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git