From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: 苏辉 <sh_def@163.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk: use REQ_OP_WRITE instead of hard code
Date: Mon, 19 Oct 2020 14:32:52 +0000 [thread overview]
Message-ID: <SN4PR0401MB3598973510611B1732B5B04B9B1E0@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: 3e965865.5946.17541447519.Coremail.sh_def@163.com
On 19/10/2020 16:30, 苏辉 wrote:
> Yeah, you are right, thanks for your explanation<br/><br/>Maybe we should define a MASK to do this?
Why? I personally find a '& 1' way more understandable than a
REQ_OP_IS_WRITE_MASK or sth like that. The former I can just read,
for the latter I would need to look up the definition to be able to
understand the code.
prev parent reply other threads:[~2020-10-19 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 13:50 [PATCH] blk: use REQ_OP_WRITE instead of hard code Hui Su
2020-10-19 14:09 ` Johannes Thumshirn
2020-10-19 14:30 ` 苏辉
2020-10-19 14:32 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB3598973510611B1732B5B04B9B1E0@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sh_def@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).