From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Christoph Hellwig <hch@lst.de>, "axboe@fb.com" <axboe@fb.com>
Cc: "ming.lei@redhat.com" <ming.lei@redhat.com>,
Matias Bjorling <mb@lightnvm.io>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 10/10] block: mark blk_rq_bio_prep as inline
Date: Mon, 13 May 2019 14:57:26 +0000 [thread overview]
Message-ID: <SN6PR04MB45278876D87AE2259FFEA61F860F0@SN6PR04MB4527.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190513063754.1520-11-hch@lst.de
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 05/12/2019 11:39 PM, Christoph Hellwig wrote:
> This function just has a few trivial assignments, has two callers with
> one of them being in the fastpath.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-core.c | 11 -----------
> block/blk.h | 13 ++++++++++++-
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index c894c9887dca..9405388ac658 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1473,17 +1473,6 @@ bool blk_update_request(struct request *req, blk_status_t error,
> }
> EXPORT_SYMBOL_GPL(blk_update_request);
>
> -void blk_rq_bio_prep(struct request *rq, struct bio *bio, unsigned int nr_segs)
> -{
> - rq->nr_phys_segments = nr_segs;
> - rq->__data_len = bio->bi_iter.bi_size;
> - rq->bio = rq->biotail = bio;
> - rq->ioprio = bio_prio(bio);
> -
> - if (bio->bi_disk)
> - rq->rq_disk = bio->bi_disk;
> -}
> -
> #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
> /**
> * rq_flush_dcache_pages - Helper function to flush all pages in a request
> diff --git a/block/blk.h b/block/blk.h
> index 5352cdb876a6..cbb0995ed17e 100644
> --- a/block/blk.h
> +++ b/block/blk.h
> @@ -51,7 +51,6 @@ struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q,
> void blk_free_flush_queue(struct blk_flush_queue *q);
>
> void blk_exit_queue(struct request_queue *q);
> -void blk_rq_bio_prep(struct request *rq, struct bio *bio, unsigned int nr_segs);
> void blk_freeze_queue(struct request_queue *q);
>
> static inline void blk_queue_enter_live(struct request_queue *q)
> @@ -100,6 +99,18 @@ static inline bool bvec_gap_to_prev(struct request_queue *q,
> return __bvec_gap_to_prev(q, bprv, offset);
> }
>
> +static inline void blk_rq_bio_prep(struct request *rq, struct bio *bio,
> + unsigned int nr_segs)
> +{
> + rq->nr_phys_segments = nr_segs;
> + rq->__data_len = bio->bi_iter.bi_size;
> + rq->bio = rq->biotail = bio;
> + rq->ioprio = bio_prio(bio);
> +
> + if (bio->bi_disk)
> + rq->rq_disk = bio->bi_disk;
> +}
> +
> #ifdef CONFIG_BLK_DEV_INTEGRITY
> void blk_flush_integrity(void);
> bool __bio_integrity_endio(struct bio *);
>
next prev parent reply other threads:[~2019-05-13 14:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 6:37 fix nr_phys_segments vs iterators accounting Christoph Hellwig
2019-05-13 6:37 ` [PATCH 01/10] block: don't decrement nr_phys_segments for physically contigous segments Christoph Hellwig
2019-05-13 9:45 ` Ming Lei
2019-05-13 12:03 ` Christoph Hellwig
2019-05-13 12:37 ` Christoph Hellwig
2019-05-14 4:36 ` Ming Lei
2019-05-14 5:14 ` Christoph Hellwig
2019-05-14 9:05 ` Ming Lei
2019-05-14 13:51 ` Christoph Hellwig
2019-05-14 13:57 ` Hannes Reinecke
2019-05-14 14:27 ` Ming Lei
2019-05-14 14:31 ` Christoph Hellwig
2019-05-14 14:32 ` Christoph Hellwig
2019-05-13 6:37 ` [PATCH 02/10] block: force an unlimited segment size on queues with a virt boundary Christoph Hellwig
2019-05-15 8:19 ` Ming Lei
2019-05-13 6:37 ` [PATCH 03/10] block: remove the segment size check in bio_will_gap Christoph Hellwig
2019-05-15 8:34 ` Ming Lei
2019-05-13 6:37 ` [PATCH 04/10] block: remove the bi_seg_{front,back}_size fields in struct bio Christoph Hellwig
2019-05-13 6:37 ` [PATCH 05/10] block: initialize the write priority in blk_rq_bio_prep Christoph Hellwig
2019-05-13 15:04 ` Chaitanya Kulkarni
2019-05-13 6:37 ` [PATCH 06/10] block: remove blk_init_request_from_bio Christoph Hellwig
2019-05-13 6:37 ` [PATCH 07/10] block: remove the bi_phys_segments field in struct bio Christoph Hellwig
2019-05-13 6:37 ` [PATCH 08/10] block: simplify blk_recalc_rq_segments Christoph Hellwig
2019-05-13 6:37 ` [PATCH 09/10] block: untangle the end of blk_bio_segment_split Christoph Hellwig
2019-05-13 6:37 ` [PATCH 10/10] block: mark blk_rq_bio_prep as inline Christoph Hellwig
2019-05-13 14:57 ` Chaitanya Kulkarni [this message]
[not found] ` <CGME20190513063855epcas5p33ef8c4c0a0055bd0b66eadc859796f0f@epcms2p6>
2019-05-13 7:34 ` [PATCH 05/10] block: initialize the write priority in blk_rq_bio_prep Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB45278876D87AE2259FFEA61F860F0@SN6PR04MB4527.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).