linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Minwoo Im <minwoo.im.dev@gmail.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: Move tag field position in struct request
Date: Mon, 29 Apr 2019 03:16:39 +0000	[thread overview]
Message-ID: <SN6PR04MB4527CECFE2541520C05AABB786390@SN6PR04MB4527.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190428074803.19484-1-minwoo.im.dev@gmail.com

If Jens is okay with this change then :-

Reviewed-by : Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>.

On 4/28/19 12:48 AM, Minwoo Im wrote:
> __data_len and __sector are internal fields which should not be accessed
> directly in driver-level like the comment above it. But, tag field can
> be accessed by driver level directly so that we need to make the comment
> right by moving it to some other place.
> 
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
>   include/linux/blkdev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 317ab30d2904..639ca948d644 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -137,11 +137,11 @@ struct request {
>   	unsigned int cmd_flags;		/* op and common flags */
>   	req_flags_t rq_flags;
>   
> +	int tag;
>   	int internal_tag;
>   
>   	/* the following two fields are internal, NEVER access directly */
>   	unsigned int __data_len;	/* total data len */
> -	int tag;
>   	sector_t __sector;		/* sector cursor */
>   
>   	struct bio *bio;
> 


  parent reply	other threads:[~2019-04-29  3:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28  7:48 [PATCH] block: Move tag field position in struct request Minwoo Im
2019-04-28 12:03 ` Christoph Hellwig
2019-04-29  3:16 ` Chaitanya Kulkarni [this message]
2019-05-13 16:55 ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR04MB4527CECFE2541520C05AABB786390@SN6PR04MB4527.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).