RE: [PATCH RFC v7 12/12] hpsa: enable host_tagset and switch to MQ

From: <Don.Brace@microchip.com>
To: <john.garry@huawei.com>, <hare@suse.de>, <don.brace@microsemi.com>
Cc: <axboe@kernel.dk>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <kashyap.desai@broadcom.com>,
	<sumit.saxena@broadcom.com>, <ming.lei@redhat.com>,
	<bvanassche@acm.org>, <hare@suse.com>, <hch@lst.de>,
	<shivasharan.srikanteshwara@broadcom.com>,
	<linux-block@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<esc.storagedev@microsemi.com>, <chenxiang66@hisilicon.com>,
	<megaraidlinux.pdl@broadcom.com>
Subject: RE: [PATCH RFC v7 12/12] hpsa: enable host_tagset and switch to MQ
Date: Fri, 14 Aug 2020 21:04:15 +0000	[thread overview]
Message-ID: <SN6PR11MB2848E10B3322C7186B82F1BCE1400@SN6PR11MB2848.namprd11.prod.outlook.com> (raw)
In-Reply-To: <013d4ba6-9173-e791-8e36-8393bde73588@huawei.com>

Subject: Re: [PATCH RFC v7 12/12] hpsa: enable host_tagset and switch to MQ

> I'll continue with more I/O stress testing.

>>ok, great. Please let me know about your testing, as I might just add that series to the v8 branch.

>>Cheers,
>>John

I cloned your branch from https://github.com/hisilicon/kernel-dev
  and checkout branch: origin/private-topic-blk-mq-shared-tags-rfc-v7

By themselves, the branch compiled but the driver did not load.

I cherry-picked the following patches from Hannes:
  git://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
  branch: reserved-tags.v6

6a9d1a96ea41 hpsa: move hpsa_hba_inquiry after scsi_add_host()
eeb5cd1fca58 hpsa: use reserved commands
	confict: removal of function hpsa_get_cmd_index,
               non-functional issue.
7df7d8382902 hpsa: use scsi_host_busy_iter() to traverse outstanding commands
485881d6d8dc hpsa: drop refcount field from CommandList
c4980ad5e5cb scsi: implement reserved command handling
	conflict: drivers/scsi/scsi_lib.c
               minor context issue adding comment,
               non-functional issue.
34d03fa945c0 scsi: add scsi_{get,put}_internal_cmd() helper
	conflict: drivers/scsi/scsi_lib.c
               minor context issue around scsi_get_internal_cmd
               when adding new comment,
               non-functional issue
4556e50450c8 block: add flag for internal commands
138125f74b25 scsi: hpsa: Lift {BIG_,}IOCTL_Command_struct copy{in,out} into hpsa_ioctl()
cb17c1b69b17 scsi: hpsa: Don't bother with vmalloc for BIG_IOCTL_Command_struct
10100ffd5f65 scsi: hpsa: Get rid of compat_alloc_user_space()
06b43f968db5 scsi: hpsa: hpsa_ioctl(): Tidy up a bit
a381637f8a6e scsi: use real inquiry data when initialising devices
6e9884aefe66 scsi: Use dummy inquiry data for the host device
77dcb92c31ae scsi: revamp host device handling

After the above patches were applied, the driver loaded and I ran the following tests:
insmod/rmmod
reboot
Ran an I/O stress test consisting of:
	6 SATA HBA disks
	2 SAS HBA disks
	2 RAID 5 volumes using 3 SAS HDDs
	2 RAID 5 volumes using 3 SAS SSDs (ioaccel enabled)

	1) fio tests to raw disks.
	2) mke2fs tests
	3) mount
	4) fio to file systems
	5) umount
	6) fsck

	And running reset tests in parallel to the above 6 tests using sg_reset

I ran some performance tests to HBA and LOGICAL VOLUMES and did not find a performance regression.

We are also reconsidering changing smartpqi over to use host tags but in some preliminary performance tests, I found a performance regression.
Note: I only used your V7 patches for smartpqi.
      I have not had time to determine what is causing this, but wanted to make note of this.

For hpsa:

With all of the patches noted above,
Tested-by: Don Brace <don.brace@microsemi.com>

For hpsa specific patches:
Reviewed-by: Don Brace <don.brace@microsemi.com>

Thanks for your input and your patches,
Don