linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] blktrace: fix trace buffer leak and limit trace buffer size
Date: Tue, 30 Mar 2021 10:04:05 +0800	[thread overview]
Message-ID: <YGKHFbQ6vfdVroZ7@T590> (raw)
In-Reply-To: <20210323081440.81343-1-ming.lei@redhat.com>

On Tue, Mar 23, 2021 at 04:14:38PM +0800, Ming Lei wrote:
> blktrace may pass big trace buffer size via '-b', meantime the system
> may have lots of CPU cores, so too much memory can be allocated for
> blktrace.
> 
> The 1st patch shutdown bltrace in blkdev_close() in case of task
> exiting, for avoiding trace buffer leak.
> 
> The 2nd patch limits max trace buffer size for avoiding potential
> OOM.
> 
> 
> Ming Lei (2):
>   block: shutdown blktrace in case of fatal signal pending
>   blktrace: limit allowed total trace buffer size
> 
>  fs/block_dev.c          |  6 ++++++
>  kernel/trace/blktrace.c | 32 ++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+)

Hello Guys,

Ping...

BTW, this is another OOM risk in blktrace userspace which is caused by
mlock(16 * buffer_size) * nr_cpus, so I think we need to avoid memory
leak caused by OOM.


Thanks,
Ming


      parent reply	other threads:[~2021-03-30  2:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  8:14 [PATCH 0/2] blktrace: fix trace buffer leak and limit trace buffer size Ming Lei
2021-03-23  8:14 ` [PATCH 1/2] block: shutdown blktrace in case of fatal signal pending Ming Lei
2021-03-30 16:53   ` Christoph Hellwig
2021-03-31  0:16     ` Ming Lei
2021-04-02 17:27       ` Christoph Hellwig
2021-04-03  8:10         ` Ming Lei
2021-04-03  9:04           ` Ming Lei
2021-04-06  6:30           ` Christoph Hellwig
2021-03-23  8:14 ` [PATCH 2/2] blktrace: limit allowed total trace buffer size Ming Lei
2021-03-30  2:57   ` Su Yue
2021-03-30  3:55     ` Ming Lei
2021-03-30 16:57   ` Christoph Hellwig
2021-03-30  2:04 ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGKHFbQ6vfdVroZ7@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).