linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: lsf-pc@lists.linux-foundation.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	Josh Hunt <johunt@akamai.com>
Subject: Re: [LSF/MM/BPF TOPIC] Block device congestion
Date: Tue, 11 May 2021 10:57:38 +0800	[thread overview]
Message-ID: <YJnyojvYN5PUc97A@T590> (raw)
In-Reply-To: <YJlx9+FQUBu5HmcI@casper.infradead.org>

On Mon, May 10, 2021 at 06:48:39PM +0100, Matthew Wilcox wrote:
> 
> I wish to re-nominate this topic from last year:
> 
> https://lore.kernel.org/linux-mm/20191231125908.GD6788@bombadil.infradead.org/
> 
> I don't think we've made any progress on it, and likely won't until
> everybody is forced into a room and the doors are locked.
> 

> >> Jens, is something supposed to be calling clear_bdi_congested() in the
> >> block layer?  blk_clear_congested() used to exist until October 29th
> >> last year.  Or is something else supposed to be waking up tasks that
> >> are sleeping on congestion?
> 
> Congestion isn't there anymore. It was always broken as a concept imho,
> since it was inherently racy. We used the old batching mechanism in the
> legacy stack to signal it, and it only worked for some devices.

The old batching and congestion was helpful for some slow devices, since
batching can avoid to submit IOs from different tasks concurrently to
same queue when queue is busy, so IO order in same task is maintained.

I believe Josh is struggling with this issue, and we had one offline
talk about this issue.

And there was another such old discussion too:

https://lore.kernel.org/linux-scsi/20191203022337.GE25002@ming.t460p/



Thanks,
Ming


      reply	other threads:[~2021-05-11  2:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 17:48 [LSF/MM/BPF TOPIC] Block device congestion Matthew Wilcox
2021-05-11  2:57 ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJnyojvYN5PUc97A@T590 \
    --to=ming.lei@redhat.com \
    --cc=johunt@akamai.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).