From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 822F8C48BE5 for ; Mon, 21 Jun 2021 08:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67F52611BD for ; Mon, 21 Jun 2021 08:39:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbhFUIle (ORCPT ); Mon, 21 Jun 2021 04:41:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25448 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbhFUIlc (ORCPT ); Mon, 21 Jun 2021 04:41:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624264758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=awsNZMMAsK23YLNOqGpugl5EnSbnJjbUBrI+opZ2Ba0=; b=ffwQcyyIlFYKcL6quvUngqnyPjyFf8/flpnj+cka6FIt4GbNb7jimnel+fSMZlxsiXmyCZ DFc+qYKOSwj2HYlxblKyzGffOWwqKqq9DpU3qBzf9EWxWHML6OZnG8QLj78jsvag611sTY 8UL4xuABKSTrt7QwT9mmX26GcW0Dagc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-9Ov8so-TNXeyvXUielGzFg-1; Mon, 21 Jun 2021 04:39:16 -0400 X-MC-Unique: 9Ov8so-TNXeyvXUielGzFg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BE561922035; Mon, 21 Jun 2021 08:39:15 +0000 (UTC) Received: from T590 (ovpn-13-237.pek2.redhat.com [10.72.13.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 854A35DA2D; Mon, 21 Jun 2021 08:38:59 +0000 (UTC) Date: Mon, 21 Jun 2021 16:38:54 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Mike Snitzer , linux-block@vger.kernel.org, Jeffle Xu , dm-devel@redhat.com, Hannes Reinecke , Chaitanya Kulkarni Subject: Re: [RFC PATCH V2 1/3] block: add helper of blk_queue_poll Message-ID: References: <20210617103549.930311-1-ming.lei@redhat.com> <20210617103549.930311-2-ming.lei@redhat.com> <20210621072036.GB6651@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621072036.GB6651@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jun 21, 2021 at 09:20:36AM +0200, Christoph Hellwig wrote: > On Thu, Jun 17, 2021 at 06:35:47PM +0800, Ming Lei wrote: > > There has been 3 users, and will be more, so add one such helper. > > > > Reviewed-by: Chaitanya Kulkarni > > Reviewed-by: Jeffle Xu > > Reviewed-by: Hannes Reinecke > > Signed-off-by: Ming Lei > > I still don't like hiding a simple flag test like this, it just adds > another step to grepping what is going on. It is actually one pattern in block layer since there is so many such macros of blk_queue_*. And it makes the check line shorter. Thanks, Ming