From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org, "Michal Koutný" <mkoutny@suse.com>,
"Dan Schatzberg" <schatzberg.dan@gmail.com>
Subject: Re: [PATCH 2/6] loop: conver timer for monitoring idle worker into dwork
Date: Thu, 8 Jul 2021 15:23:07 +0800 [thread overview]
Message-ID: <YOan25RwpSs/A27W@T590> (raw)
In-Reply-To: <20210706055227.GG17027@lst.de>
On Tue, Jul 06, 2021 at 07:52:27AM +0200, Christoph Hellwig wrote:
> On Mon, Jul 05, 2021 at 06:26:03PM +0800, Ming Lei wrote:
> > +static void loop_free_idle_workers(struct work_struct *work)
> > +{
> > + struct loop_device *lo = container_of(work, struct loop_device,
> > + idle_work.work);
> > + struct loop_worker *pos, *worker;
> > +
> > + spin_lock(&lo->lo_work_lock);
> > + list_for_each_entry_safe(worker, pos, &lo->idle_worker_list,
> > + idle_list) {
> > + if (time_is_after_jiffies(worker->last_ran_at +
> > + LOOP_IDLE_WORKER_TIMEOUT))
> > + break;
> > + list_del(&worker->idle_list);
> > + rb_erase(&worker->rb_node, &lo->worker_tree);
> > + css_put(worker->blkcg_css);
> > + kfree(worker);
> > + }
> > + if (!list_empty(&lo->idle_worker_list))
> > + loop_set_timer(lo);
> > + spin_unlock(&lo->lo_work_lock);
> > +}
> > +
> > +
>
> Double empty line. But that whole fact that the loop driver badly
> reimplements work queues is just fucked up. We need to revert this
> shit.
Can you explain why work queues are bad for fixing this blkcg/memcg
issue?
Thanks,
Ming
next prev parent reply other threads:[~2021-07-08 7:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 10:26 [PATCH 0/6] loop: cleanup charging io to mem/blkcg Ming Lei
2021-07-05 10:26 ` [PATCH 1/6] loop: clean up blkcg association Ming Lei
2021-07-06 5:51 ` Christoph Hellwig
2021-07-08 7:20 ` Ming Lei
2021-07-05 10:26 ` [PATCH 2/6] loop: conver timer for monitoring idle worker into dwork Ming Lei
2021-07-06 5:52 ` Christoph Hellwig
2021-07-08 7:23 ` Ming Lei [this message]
2021-07-05 10:26 ` [PATCH 3/6] loop: add __loop_free_idle_workers() for covering freeing workers in clearing FD Ming Lei
2021-07-05 10:26 ` [PATCH 4/6] loop: improve loop_process_work Ming Lei
2021-07-06 5:54 ` Christoph Hellwig
2021-07-05 10:26 ` [PATCH 5/6] loop: use xarray to store workers Ming Lei
2021-07-05 10:26 ` [PATCH 6/6] loop: don't add worker into idle list Ming Lei
2021-07-06 13:55 ` Dan Schatzberg
2021-07-07 3:19 ` Ming Lei
2021-07-07 13:55 ` Dan Schatzberg
2021-07-08 6:58 ` Ming Lei
2021-07-08 14:16 ` Dan Schatzberg
2021-07-08 15:01 ` Ming Lei
2021-07-08 15:15 ` Dan Schatzberg
2021-07-09 0:49 ` Ming Lei
2021-07-09 13:47 ` Dan Schatzberg
2021-07-08 14:41 ` Dan Schatzberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOan25RwpSs/A27W@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=schatzberg.dan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).