From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C49F4C07E9B for ; Wed, 21 Jul 2021 06:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA52A61009 for ; Wed, 21 Jul 2021 06:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233625AbhGUF5d (ORCPT ); Wed, 21 Jul 2021 01:57:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230057AbhGUF5W (ORCPT ); Wed, 21 Jul 2021 01:57:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 317B3C061574; Tue, 20 Jul 2021 23:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XYeBKSl9pF1jy3vtrjCu+kIPIp8ICH8F1p/bMzcagKs=; b=YPTD1oSDMQ1tqkeq4zo2uX9zjo XAzfqnrxfDYo/qWpdOxsmXM14GEqxAzpFjUhG3a64UQuaiihyFyO+bjrrRbOqzo17tmN1kSHPhubx lCtR/G3qnIcXm/tbiJDDp0JB8s7FfYg9tHPzbTWIFGm/BKTCLDr9u8Bqk6lqhtxnr+jH9m8pv1JFk mOa5jAOcCj0znZcMrZIYiVmJ0hwBimK9G8x3coK6W+C25rfCW2q0au1bHVzrO3rodWo8RUBTxLVVb 0XQ2LiqisLcoCFufVMKzckKnFYneDTQ/4JsWVdWPsH42mOdjWB6dUQBQYIcqP/V7XPdddbuYsvhqN Zf8qZH4w==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m65rY-008svf-Bd; Wed, 21 Jul 2021 06:37:50 +0000 Date: Wed, 21 Jul 2021 07:37:48 +0100 From: Christoph Hellwig To: Naohiro Aota Cc: linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe , David Sterba , Chaitanya Kulkarni Subject: Re: [PATCH v2 2/3] btrfs: fix argument type of btrfs_bio_clone_partial() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jul 21, 2021 at 03:26:59PM +0900, Naohiro Aota wrote: > btrfs_bio = btrfs_io_bio(bio); > btrfs_io_bio_init(btrfs_bio); > > - bio_trim(bio, offset >> 9, size >> 9); > + bio_trim(bio, (sector_t)offset >> 9, (sector_t)size >> 9); No need for the casts when shifting down.