From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05457C6377A for ; Thu, 22 Jul 2021 02:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E04E6611C1 for ; Thu, 22 Jul 2021 02:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbhGVBZO (ORCPT ); Wed, 21 Jul 2021 21:25:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26858 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbhGVBZB (ORCPT ); Wed, 21 Jul 2021 21:25:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626919537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E+YMc/wxbNi5MWP7hujgK9VTZ4gXb9QxZrNQFu14HLQ=; b=ScWRYNIr5CLRTX92z7VrUQqfRxn0n1G91DpiTj3s6SIBFG/J/wLvUkXXqPdFoKbBXLrS1t gCsp0Cbee6A+yFrdtU6qdwn4+lt32/IIGRv4XGO5KRupyxPiioVzyN8roUxjfi0HDS1orz zS365cdIb8zVjxAD9tjieEnSVUvr6Vg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-PlLkKXRpMR-pK_SDFnb5Kw-1; Wed, 21 Jul 2021 22:05:33 -0400 X-MC-Unique: PlLkKXRpMR-pK_SDFnb5Kw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23EBB107ACF5; Thu, 22 Jul 2021 02:05:32 +0000 (UTC) Received: from T590 (ovpn-13-66.pek2.redhat.com [10.72.13.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BAA46091B; Thu, 22 Jul 2021 02:05:24 +0000 (UTC) Date: Thu, 22 Jul 2021 10:05:19 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , David Sterba , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 1/8] block: delay freeing the gendisk Message-ID: References: <20210721153523.103818-1-hch@lst.de> <20210721153523.103818-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210721153523.103818-2-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jul 21, 2021 at 05:35:16PM +0200, Christoph Hellwig wrote: > blkdev_get_no_open acquires a reference to the block_device through > the block device inode and then tries to acquire a device model > reference to the gendisk. But at this point the disk migh already > be freed (although the race is free). Fix this by only freeing the > gendisk from the whole device bdevs ->free_inode callback as well. > > Fixes: 22ae8ce8b892 ("block: simplify bdev/disk lookup in blkdev_get") > Signed-off-by: Christoph Hellwig Reviewed-by: Ming Lei -- Ming