From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6AC4C63797 for ; Thu, 22 Jul 2021 08:32:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B26F6127C for ; Thu, 22 Jul 2021 08:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231259AbhGVHv4 (ORCPT ); Thu, 22 Jul 2021 03:51:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49364 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231250AbhGVHvy (ORCPT ); Thu, 22 Jul 2021 03:51:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626942749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gZ1+6HeYT2ED4bM+Pad+8J83+hcuj946cQYelhBSjI8=; b=iLYxIb+dg/r0ylLBJ1BLCeuHvbxx5pN3rHAgY7+r4fFNJWmY2cno3oRu7UusO1JaJ10+AI CXGMelSx2PfahCwOhwe3ViJRzTRE8RX0ci/6SUOMaJtEl1dqnoCR4Pf/AXFgyPzJO91WEk NOstYykAMr0DSsXXS+WoC0HYFbRCvWY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-427-pQ6N-3WJOZqxlmoRQrG2tA-1; Thu, 22 Jul 2021 04:32:26 -0400 X-MC-Unique: pQ6N-3WJOZqxlmoRQrG2tA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6B7B804311; Thu, 22 Jul 2021 08:32:24 +0000 (UTC) Received: from T590 (ovpn-13-219.pek2.redhat.com [10.72.13.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7973E5D6B1; Thu, 22 Jul 2021 08:32:17 +0000 (UTC) Date: Thu, 22 Jul 2021 16:32:11 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , David Sterba , Naohiro Aota , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 4/9] block: allocate bd_meta_info later in add_partitions Message-ID: References: <20210722075402.983367-1-hch@lst.de> <20210722075402.983367-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722075402.983367-5-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jul 22, 2021 at 09:53:57AM +0200, Christoph Hellwig wrote: > Move the allocation of bd_meta_info after initializing the struct device > to avoid the special bdput error handling path. > > Signed-off-by: Christoph Hellwig Reviewed-by: Ming Lei -- Ming