From: Ming Lei <ming.lei@redhat.com>
To: Wen Xiong <wenxiong@us.ibm.com>
Cc: dwagner@suse.de, axboe@kernel.dk, gregkh@linuxfoundation.org,
hare@suse.de, hch@lst.de, john.garry@huawei.com,
linux-block@vger.kernel.org, sagi@grimberg.me,
tglx@linutronix.de
Subject: Re: [PATCH V6 0/3] blk-mq: fix blk_mq_alloc_request_hctx
Date: Fri, 23 Jul 2021 16:16:30 +0800 [thread overview]
Message-ID: <YPp63niga//Q6GLV@T590> (raw)
In-Reply-To: <OFDADF39F5.DDB99A55-ON0025871A.00794382-0025871A.00797A2E@ibm.com>
On Thu, Jul 22, 2021 at 10:06:51PM +0000, Wen Xiong wrote:
> > Wen Xiong has verified V4 in her nvmef test.
>
> >>FWIW, I am testing this series right now. I observe hanging I/Os
> >>again, but I am not totally sure if my test setup is working
> >>properly. Working on it. I'll keep you posted.
>
>
> I built the latest upstream(v5.14-rc2) + Ming's V6 + Daniel's V3: didn't work.
>
Hi Wenxiong,
V6 is basically same with V4, can you figure out where the failure
comes?(v5.14-rc2, V6 or Daniel's V3)
I verified that V6 works as expected by tracing blk_mq_update_queue_map():
#!/usr/bin/bpftrace
#include <linux/blk-mq.h>
kprobe:blk_mq_update_queue_map
{
@in_map[tid]=1;
@set[tid] = (struct blk_mq_tag_set *)arg0;
@ms[tid] = kstack;
}
kretprobe:blk_mq_update_queue_map
/@in_map[tid]==1/
{
$s = @set[tid];
$m = (struct blk_mq_queue_map *)$s->map;
printf("%s %d: %s queues %d use_managed_irq %d\n",
comm, pid, @ms[tid], $s->nr_hw_queues, $m->use_managed_irq);
}
Thanks,
Ming
next prev parent reply other threads:[~2021-07-23 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 9:52 [PATCH V6 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-22 9:52 ` [PATCH V6 1/3] genirq: add device_has_managed_msi_irq Ming Lei
2021-07-22 13:05 ` Christoph Hellwig
2021-07-22 9:52 ` [PATCH V6 2/3] blk-mq: mark if one queue map uses managed irq Ming Lei
2021-07-22 13:06 ` Christoph Hellwig
2021-07-22 15:40 ` Ming Lei
2021-07-22 16:06 ` Christoph Hellwig
2021-07-22 9:52 ` [PATCH V6 3/3] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-08-18 9:38 ` John Garry
2021-08-18 10:32 ` Ming Lei
2021-07-22 13:12 ` [PATCH V6 0/3] blk-mq: fix blk_mq_alloc_request_hctx Daniel Wagner
[not found] ` <OFDADF39F5.DDB99A55-ON0025871A.00794382-0025871A.00797A2E@ibm.com>
2021-07-23 8:16 ` Ming Lei [this message]
[not found] ` <OF2C4681CD.AF20CBB4-ON0025871E.004D37B6-0025871E.004E3B9F@ibm.com>
2021-07-26 17:06 ` Daniel Wagner
2021-08-18 9:11 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPp63niga//Q6GLV@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).