archive mirror
 help / color / mirror / Atom feed
From: Niklas Cassel <>
To: Ming Lei <>
Cc: Jens Axboe <>,
	Bart Van Assche <>,
	Damien Le Moal <>,
	Paolo Valente <>,
	"" <>,
	"" <>
Subject: Re: [RFC PATCH 1/2] blk-mq: don't call callbacks for requests that bypassed the scheduler
Date: Mon, 30 Aug 2021 09:48:06 +0000	[thread overview]
Message-ID: <YSypVLe8vxmA+pUn@x1-carbon> (raw)
In-Reply-To: <YSjoZ/cul4w2l8tG@T590>

On Fri, Aug 27, 2021 at 09:28:07PM +0800, Ming Lei wrote:
> On Fri, Aug 27, 2021 at 12:41:31PM +0000, Niklas Cassel wrote:
> > From: Niklas Cassel <>
> > 
> > Currently, __blk_mq_alloc_request() calls ops.prepare_request and sets
> > 
> > Therefore, (if the request is not a flush) the RQF_ELVPRIV flag will be
> > set for the request in blk_mq_submit_bio(), regardless if the request
> > was submitted to a scheduler, or bypassed the scheduler.
> > 
> > Later, blk_mq_free_request() checks if the RQF_ELVPRIV flag is set,
> > if it is, the ops.finish_request callback will be called.
> > 
> > The problem with this is that the finish_request scheduler callback
> > will be called for requests that bypassed the scheduler.
> > 
> > Fix this by calling the scheduler ops.prepare_request callback, and
> > set the RQF_ELVPRIV flag only immediately before calling the insert
> > callback.
> One request could be inserted more than one times, such as requeue,
> however __blk_mq_alloc_request() is just run once, so is it fine to
> call ->prepare_request more than one time for same request?

Calling ->prepare_request multiple times is fine.
All the different I/O schedulers (BFQ, mq-deadline, kyber)
simply use .prepare_request to clear/set elv->priv to a fixed value.

> Or I am wondering why not call ->prepare_request when the following
> check is true?
> 	if (e && e->type->ops.prepare_request && !op_is_flush(data->cmd_flags) &&
> 		!blk_op_is_passthrough(data->cmd_flags))
> 		e->type->ops.prepare_request()

That might work, and might be a nicer solution indeed.

If a request got plugged, it will be inserted to the scheduler through
blk_flush_plug_list() -> blk_mq_flush_plug_list() -> blk_mq_sched_insert_requests()
which will insert them unconditionally.
In this case. we know that !op_is_flush() (because if it was, blk_mq_submit_bio()
would have inserted directly.)

If we didn't plug, we do blk_mq_sched_insert_request(), which will add it if
blk_mq_sched_bypass_insert() returns false:

blk_mq_sched_bypass_insert() is defined as:

        if ((rq->rq_flags & RQF_FLUSH_SEQ) || blk_rq_is_passthrough(rq))
                return true;
Also in this case. we know that !op_is_flush() (blk_mq_submit_bio() would have
inserted directly.)

So, we could easily add && !blk_op_is_passthrough(data->cmd_flags) to the
->prepare_request condition in blk_mq_rq_ctx_init() like you suggested,
but since the bypass condition also seems to look at RQF_FLUSH_SEQ, wouldn't
we need to add RQF_FLUSH_SEQ to the condition in blk_mq_rq_ctx_init() as well?

This flag is set after blk_mq_rq_ctx_init(). Are we sure that RQF_FLUSH_SEQ
flag will only be set for a request which op_is_flush() returned true?

(If so, then only adding  && !blk_op_is_passthrough(data->cmd_flags) should
be fine.)

Kind regards,

  reply	other threads:[~2021-08-30  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 12:41 [RFC PATCH 0/2] improve io scheduler callback triggering Niklas Cassel
2021-08-27 12:41 ` [RFC PATCH 1/2] blk-mq: don't call callbacks for requests that bypassed the scheduler Niklas Cassel
2021-08-27 13:28   ` Ming Lei
2021-08-30  9:48     ` Niklas Cassel [this message]
2021-08-30 10:11       ` Ming Lei
2021-09-07 12:59         ` Niklas Cassel
2021-08-27 12:41 ` [RFC PATCH 2/2] Revert "mq-deadline: Fix request accounting" Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSypVLe8vxmA+pUn@x1-carbon \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).