From: Phillip Potter <firstname.lastname@example.org>
To: Lukas Prediger <email@example.com>
Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org,
Subject: Re: [PATCH v3] drivers/cdrom: improved ioctl for media change detection
Date: Sun, 12 Sep 2021 19:04:43 +0100 [thread overview]
Message-ID: <YT5BO7bUMMkwNCTh@equinox> (raw)
On Sat, Sep 11, 2021 at 08:48:17PM +0300, Lukas Prediger wrote:
> Hi Randy, Hi Phil,
> >> Hi Lukas,
> >> Just a minor nit:
> >> On 9/10/21 2:16 PM, Lukas Prediger wrote:
> >> > +#define MEDIA_CHANGED_FLAG 0x1 /* Last detected media change was more \
> >> > + * recent than last_media_change set by\
> >> > + * caller. \
> >> > + */
> >> Drop the "continuation" backslashes.
> >> They are not needed.
> >> thanks.
> >> --
> >> ~Randy
> Hm, my IDE was complaining about these but I just tested building without and
> that worked fine. No idea what that was about then..
> > Dear Lukas,
> > Happy to take these out for you and save you resubmitting.
> > I'm very happy with patch anyway. Once I hear back from
> > you I'll send onto Jens with my approval after one final test :-)
> That would be very nice of you!
> > Thanks again for the code.
> My pleasure, and thanks for the helpful feedback!
> > Regards,
> > Phil
> Best regards,
This v3 patch does not apply to my tree, or the mainline one for that
matter. A few problems I've noticed that are the cause of this:
Documentation/ioctl/cdrom.rst - this file should actually be:
Documentation/userspace-api/ioctl/cdrom.rst (and is in v2)
v3 fails on applying the changes to drivers/cdrom/cdrom.c as well, due
to two hunks failing (because of different lines preceding your
It also fails to apply the second hunk to include/uapi/linux/cdrom.h,
again due to differences in pre-existing content. Did you base this v3
patch against a different/older tree/branch?
Please advise, many thanks. As mentioned before, v2 applied perfectly
fine for me.
next prev parent reply other threads:[~2021-09-12 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 21:16 [PATCH v3] drivers/cdrom: improved ioctl for media change detection Lukas Prediger
2021-09-10 21:41 ` Randy Dunlap
2021-09-11 11:00 ` Phillip Potter
2021-09-11 17:48 ` Lukas Prediger
2021-09-12 18:04 ` Phillip Potter [this message]
2021-09-12 19:12 ` Lukas Prediger
2021-09-13 7:50 ` Phillip Potter
2021-10-06 20:52 ` Randy Dunlap
2021-10-07 23:04 ` Phillip Potter
2021-09-13 23:09 Phillip Potter
2021-09-15 2:05 ` Jens Axboe
2021-09-16 23:07 ` Phillip Potter
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).