From: Christoph Hellwig <hch@infradead.org>
To: Xie Yongji <xieyongji@bytedance.com>
Cc: axboe@kernel.dk, josef@toxicpanda.com, hch@infradead.org,
linux-block@vger.kernel.org, nbd@other.debian.org,
yixingchen@bytedance.com
Subject: Re: [PATCH 1/3] block: Add invalidate_gendisk() helper to invalidate the gendisk
Date: Mon, 13 Sep 2021 13:31:52 +0100 [thread overview]
Message-ID: <YT9EuMgnTQezWJSQ@infradead.org> (raw)
In-Reply-To: <20210913112557.191-2-xieyongji@bytedance.com>
On Mon, Sep 13, 2021 at 07:25:55PM +0800, Xie Yongji wrote:
>
> +/**
> + * invalidate_gendisk - invalidate the gendisk
> + * @disk: the struct gendisk to invalidate
> + *
> + * A helper to invalidates the gendisk. It will clean the gendisk's associated
> + * buffer/page caches and reset its internal states so that the gendisk
> + * can be reused by the drivers.
> + *
> + * Context: can sleep
> + */
> +
> +void invalidate_gendisk(struct gendisk *disk)
No need for the empty line. Also I wonder if invalidate_disk might be a
better name - except for del_gendisk we don't really use _gendisk in
function names at all.
> +extern void invalidate_gendisk(struct gendisk *gp);
No need for the extern. Also I'd name the argument disk, just as in
the actual implementation.
The actual functionality looks good to me despite these nitpicks.
next prev parent reply other threads:[~2021-09-13 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 11:25 [PATCH 0/3] Add invalidate_gendisk() helper for drivers to invalidate the gendisk Xie Yongji
2021-09-13 11:25 ` [PATCH 1/3] block: Add invalidate_gendisk() helper " Xie Yongji
2021-09-13 12:31 ` Christoph Hellwig [this message]
2021-09-13 13:16 ` Yongji Xie
2021-09-13 11:25 ` [PATCH 2/3] loop: Use invalidate_gendisk() helper to invalidate gendisk Xie Yongji
2021-09-13 12:34 ` Christoph Hellwig
2021-09-13 13:14 ` Yongji Xie
2021-09-13 11:25 ` [PATCH 3/3] nbd: Use invalidate_gendisk() helper on disconnect Xie Yongji
2021-09-13 12:41 ` Christoph Hellwig
2021-09-13 13:04 ` Yongji Xie
2021-09-13 15:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT9EuMgnTQezWJSQ@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=xieyongji@bytedance.com \
--cc=yixingchen@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).