From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F90C433F5 for ; Sun, 5 Sep 2021 15:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4DF360F56 for ; Sun, 5 Sep 2021 15:12:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233765AbhIEPNp (ORCPT ); Sun, 5 Sep 2021 11:13:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:34292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbhIEPNo (ORCPT ); Sun, 5 Sep 2021 11:13:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DFEBB60C51; Sun, 5 Sep 2021 15:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630854761; bh=EJKtfZlvYjyzvF8xbB3qZsOcfE6aKYDONOl+sB/n6rU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2J0mnQMWIP0vwLBumtXea0Li6OBlqYbbFPHoPECQTbINXR5uBnR/oG0XLztJ4NzH3 TS66pj8FyXv+P6HVYNReaHE1t2FxzNgRIRDBLjwi+ltnx36Yyv01Fi85ai+fNHokOi 4DZrnowJ5+P0v3RjwxqTReJ5lVE013PEPJ6nMpcA= Date: Sun, 5 Sep 2021 17:12:39 +0200 From: Greg KH To: Ian Pilcher Cc: axboe@kernel.dk, pavel@ucw.cz, linux-leds@vger.kernel.org, linux-block@vger.kernel.org, kabel@kernel.org Subject: Re: [PATCH 09/18] ledtrig-blkdev: Periodically check devices for activity & blink LEDs Message-ID: References: <20210903204548.2745354-1-arequipeno@gmail.com> <20210903204548.2745354-10-arequipeno@gmail.com> <8b0a2244-d81c-1099-927f-cfe9b04a4285@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, Sep 05, 2021 at 09:56:58AM -0500, Ian Pilcher wrote: > On 9/5/21 9:51 AM, Greg KH wrote: > > On Sun, Sep 05, 2021 at 09:39:57AM -0500, Ian Pilcher wrote: > > > On 9/4/21 1:01 AM, Greg KH wrote: > > > > Please never use WARN_ON() in new code unless the machine is really > > > > broken and you can not do anything else here. > > > > > > Wait what? I thought that was BUG_ON. > > > > Not whan panic-on-warn is set, which is getting more and more common > > these days. > > Fair enough. What is the recommend approach to reporting a "this should > never" happen situation these days? dev_err() and handle the error properly.