linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ian Pilcher <arequipeno@gmail.com>
Cc: axboe@kernel.dk, pavel@ucw.cz, linux-leds@vger.kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, kabel@kernel.org,
	chaitanyak@nvidia.com
Subject: Re: [PATCH v3 2/3] block: export block_class for use by the blkdev LED trigger
Date: Wed, 15 Sep 2021 08:07:59 +0100	[thread overview]
Message-ID: <YUGbz1uxPNLTz6tA@infradead.org> (raw)
In-Reply-To: <20210914201713.14922-3-arequipeno@gmail.com>

NAK.  block_class has no business being used outside the core block
layer.

  reply	other threads:[~2021-09-15  7:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 20:17 [PATCH v3 0/3] Introduce block device LED trigger Ian Pilcher
2021-09-14 20:17 ` [PATCH v3 1/3] docs: Add block device (blkdev) LED trigger documentation Ian Pilcher
2021-09-14 20:17 ` [PATCH v3 2/3] block: export block_class for use by the blkdev LED trigger Ian Pilcher
2021-09-15  7:07   ` Christoph Hellwig [this message]
2021-09-14 20:17 ` [PATCH v3 3/3] leds: trigger: Add block device " Ian Pilcher
2021-09-15  5:24   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUGbz1uxPNLTz6tA@infradead.org \
    --to=hch@infradead.org \
    --cc=arequipeno@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=chaitanyak@nvidia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kabel@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).