From: Eric Biggers <email@example.com> To: Christoph Hellwig <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Satya Tangirala <email@example.com> Subject: Re: [PATCH 2/5] blk-crypto-fallback: consolidate static variables Date: Thu, 16 Sep 2021 10:28:14 -0700 [thread overview] Message-ID: <YUN+rv31Wm3firstname.lastname@example.org> (raw) In-Reply-To: <YUL0ytosYfrs7nNi@infradead.org> On Thu, Sep 16, 2021 at 08:39:54AM +0100, Christoph Hellwig wrote: > On Wed, Sep 15, 2021 at 10:50:13AM -0700, Eric Biggers wrote: > > Using "blk_crypto_fallback_*" for all these variables results in some pretty > > long names, e.g. "blk_crypto_fallback_crypt_ctx_cache" and > > "blk_crypto_fallback_num_prealloc_crypt_ctxs". This proposal gives the best of > > both worlds; the names are properly "namespaced" but there is also a shortcut to > > refer to them (struct blk_crypto_fallback *fallback = &blk_crypto_fallback). > > I'd just drop the second crypt in those. > > > If this is going to be controversial I can just drop this patch, but I was > > hoping there would be a way to make things more consistent. > > I personally detest that pattern. Not sure if that counts as > controversial or even matters :) The names are still pretty long even with the second "crypt" dropped from those two. How about just "fallback_*"? It might be clear enough from the context. Anyway, I've dropped this patch from the series for now. This can be done later we can agree on which approach to take. - Eric
next prev parent reply other threads:[~2021-09-16 17:44 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-13 1:31 [PATCH 0/5] blk-crypto cleanups Eric Biggers 2021-09-13 1:31 ` [PATCH 1/5] blk-crypto-fallback: properly prefix function and struct names Eric Biggers 2021-09-15 7:36 ` Christoph Hellwig 2021-09-13 1:31 ` [PATCH 2/5] blk-crypto-fallback: consolidate static variables Eric Biggers 2021-09-15 7:39 ` Christoph Hellwig 2021-09-15 17:50 ` Eric Biggers 2021-09-16 7:39 ` Christoph Hellwig 2021-09-16 17:28 ` Eric Biggers [this message] 2021-09-13 1:31 ` [PATCH 3/5] blk-crypto: rename keyslot-manager files to blk-crypto-profile Eric Biggers 2021-09-14 9:04 ` Ulf Hansson 2021-09-15 7:45 ` Christoph Hellwig 2021-09-15 17:40 ` Eric Biggers 2021-09-16 7:42 ` Christoph Hellwig 2021-09-13 1:31 ` [PATCH 4/5] blk-crypto: rename blk_keyslot_manager to blk_crypto_profile Eric Biggers 2021-09-14 9:04 ` Ulf Hansson 2021-09-14 21:52 ` Eric Biggers 2021-09-13 1:31 ` [PATCH 5/5] blk-crypto: update inline encryption documentation Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YUN+rv31Wm3email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/5] blk-crypto-fallback: consolidate static variables' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).