From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Lennart Poettering <lennart@poettering.net>,
Jens Axboe <axboe@fb.com>, Martijn Coenen <maco@android.com>,
linux-block@vger.kernel.org, Luca Boccassi <bluca@debian.org>,
Karel Zak <kzak@redhat.com>
Subject: Re: Is LO_FLAGS_DIRECT_IO by default a good idea?
Date: Tue, 19 Oct 2021 15:44:10 +0800 [thread overview]
Message-ID: <YW53SrKnKmn2Aa0k@T590> (raw)
In-Reply-To: <20211018150550.GA29993@lst.de>
On Mon, Oct 18, 2021 at 05:05:50PM +0200, Christoph Hellwig wrote:
> On Mon, Oct 18, 2021 at 04:19:20PM +0200, Lennart Poettering wrote:
> > A brief answer like "yes, please, enable by default" would already
> > make me happy.
>
> I thikn enabling it by default is a good idea. The only good use
> case I can think of for using buffered I/O is when the image has
> a smaller block size than supported on the host file.
Maybe we can enable it at default in kernel side, then fackback to
buffered IO if DIO is failed.
thanks,
Ming
next prev parent reply other threads:[~2021-10-19 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 14:19 Is LO_FLAGS_DIRECT_IO by default a good idea? Lennart Poettering
2021-10-18 15:05 ` Christoph Hellwig
2021-10-19 7:28 ` Lennart Poettering
2021-10-19 7:44 ` Ming Lei [this message]
2021-10-19 12:24 ` Jens Axboe
2021-10-25 10:37 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW53SrKnKmn2Aa0k@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=bluca@debian.org \
--cc=hch@lst.de \
--cc=kzak@redhat.com \
--cc=lennart@poettering.net \
--cc=linux-block@vger.kernel.org \
--cc=maco@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).